Changeset 87822ce in mainline for uspace/app/modplay/modplay.c

Timestamp:

2021-03-04T19:14:30Z (3 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

d6c4d40

Parents:

760a392

Message:

Avoid infinite loop when console communication is broken

Need to make sure callers of console_get_event_timeout() can distinguish
between timeout and I/O error. Fix all callers of console_get_event()
and console_get_event_timeout() not to enter infinite loop when console
connection is broken. Also avoid setting of errno variable.

File:

• uspace/app/modplay/modplay.c (modified) (1 diff)

uspace/app/modplay/modplay.c

@@ -174 +174 @@
         while (true) {
                 timeout = 0;
-                if (console_get_event_timeout(con, &event, &timeout))
+                rc = console_get_event_timeout(con, &event, &timeout);
+                if (rc == EOK)
                         modplay_event(&event);
+                else if (rc != ETIMEOUT)
+                        break;
+
                 if (quit)
                         break;