Changeset 867b375 in mainline for uspace/drv/bus/usb/xhci/rh.h

Timestamp:

2017-10-15T02:04:10Z (7 years ago)

Author:

Ondřej Hlavatý <aearsis@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

20eaa82

Parents:

d7869d7e

Message:

hcd_ddf_new_device refactoring

This long function is now split into parts. Instead of passing dozens of arguments, it now creates the usb_dev_t right away, and uses that to pass it along. The address_device part is now modifiable by drivers.

There is still a work to be done. The biggest problem I see is in the addressing - currently, there is usb_address_t, and for high speed transaction translating there is another address. For (near) future extensibility, we should pass address as a structure. Or even better, make a way how to reference a device, maybe in a similar way how we work with endpoints.

File:

• uspace/drv/bus/usb/xhci/rh.h (modified) (3 diffs)

uspace/drv/bus/usb/xhci/rh.h

@@ -51 +51 @@
 } xhci_port_speed_t;
 
+typedef struct hcd_roothub hcd_roothub_t;
+
 /* XHCI root hub instance */
 typedef struct {
@@ -64 +66 @@
         /* Number of hub ports. */
         uint8_t max_ports;
+
+        /* We need this to create child devices */
+        hcd_roothub_t *hcd_rh;
 } xhci_rh_t;
 
@@ -74 +79 @@
 void xhci_rh_handle_port_change(xhci_rh_t *);
 
+int xhci_rh_address_device(xhci_rh_t *, usb_speed_t, usb_tt_address_t, usb_address_t *);
+
 #endif