Changeset 84a1a54 in mainline for uspace/app/mkbd/main.c

Timestamp:

2018-01-04T20:47:53Z (6 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Children:

facacc71

Parents:

cde999a

Message:

Wrap returns of errno from main() with EXIT_RC().

Returns of error code from main() prevent type checking when errno_t
and int are considered incompatible. In order to avoid the philosophical
discussion of what should and shouldn't be returned for main(), we simply
wrap the error values and leave the answer to the question for future
generations to decide.

File:

• uspace/app/mkbd/main.c (modified) (6 diffs)

uspace/app/mkbd/main.c

@@ -222 +222 @@
                 printf("Device not found or not of USB kind: %s.\n",
                     str_error(rc));
-                return rc;
+                return EXIT_RC(rc);
         }
         
@@ -229 +229 @@
                 printf(NAME ": failed to connect to the device (handle %"
                        PRIun "): %s.\n", dev_handle, str_error(errno));
-                return errno;
+                return EXIT_RC(errno);
         }
         
@@ -239 +239 @@
                 printf(NAME ": failed to get path (handle %"
                        PRIun "): %s.\n", dev_handle, str_error(errno));
-                return ENOMEM;
+                return EXIT_RC(ENOMEM);
         }
         
@@ -250 +250 @@
                 printf("Failed to initialize report parser: %s\n",
                     str_error(rc));
-                return rc;
+                return EXIT_RC(rc);
         }
         
@@ -259 +259 @@
         if (rc != EOK) {
                 printf("Failed to get event length: %s.\n", str_error(rc));
-                return rc;
+                return EXIT_RC(rc);
         }
         
@@ -266 +266 @@
                 printf("Out of memory.\n");
                 // TODO: hangup phone?
-                return ENOMEM;
+                return EXIT_RC(ENOMEM);
         }