Changeset 7f7817a9 in mainline for uspace/app/bdsh/cmds/modules/alias/alias.c

Timestamp:

2018-12-15T21:02:22Z (5 years ago)

Author:

Matthieu Riolo <matthieu.riolo@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

ab936440

Parents:

ac2caecb

Message:

adding a validation for alias naming

File:

• uspace/app/bdsh/cmds/modules/alias/alias.c (modified) (2 diffs)

uspace/app/bdsh/cmds/modules/alias/alias.c

@@ -84 +84 @@
 }
 
+static bool valide_name(const char *name)
+{
+        while (*name != '\0') {
+                if (*name == '/')
+                        return false;
+                if (*name == ' ')
+                        return false;
+                if (*name == '\"')
+                        return false;
+                if (*name == '\'')
+                        return false;
+                if (*name == '|')
+                        return false;
+
+                name++;
+        }
+
+        return true;
+}
+
 /* Dispays help for alias in various levels */
 void help_cmd_alias(unsigned int level)
@@ -115 +135 @@
                 if ((value = str_chr(name, '=')) != NULL) {
                         name[value - name] = '\0';
+                        if (!valide_name(name)) {
+                                cli_error(CL_EFAIL, "%s: invalid alias name given\n", cmdname);
+                                free(name);
+                                return CMD_FAILURE;
+                        }
+                        
                         set_alias(name, value + 1);
                 } else {