Changeset 74017ce in mainline for uspace/srv/hid/isdv4_tablet/isdv4.c

Timestamp:

2017-11-22T17:36:54Z (6 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

7a6065c

Parents:

c4c6025

git-author:

Jiri Svoboda <jiri@…> (2017-11-22 15:53:34)

git-committer:

Jiri Svoboda <jiri@…> (2017-11-22 17:36:54)

Message:

Convert char_dev_iface users to chardev.

File:

• uspace/srv/hid/isdv4_tablet/isdv4.c (modified) (8 diffs)

uspace/srv/hid/isdv4_tablet/isdv4.c

@@ -27 +27 @@
  */
 
-#include <char_dev_iface.h>
 #include <errno.h>
+#include <io/chardev.h>
+#include <mem.h>
 #include <stdbool.h>
 #include <stdint.h>
 #include <stdlib.h>
-#include <mem.h>
 #include <thread.h>
 
@@ -298 +298 @@
         bool reading = true;
         while (reading) {
-                ssize_t read = char_dev_read(state->sess, state->buf + state->buf_end,
-                    state->buf_size - state->buf_end);
-                if (read < 0)
+                size_t nread;
+                int rc;
+
+                rc = chardev_read(state->chardev, state->buf + state->buf_end,
+                    state->buf_size - state->buf_end, &nread);
+                if (rc != EOK && nread == 0)
                         return EIO;
-                state->buf_end += read;
+                state->buf_end += nread;
 
                 size_t i = 0;
@@ -357 +360 @@
         return EOK;
 }
-static bool write_command(async_sess_t *sess, uint8_t command)
-{
-        return char_dev_write(sess, &command, 1) == 1;
+
+static bool write_command(chardev_t *chardev, uint8_t command)
+{
+        int rc;
+        size_t nwr;
+
+        rc = chardev_write(chardev, &command, 1, &nwr);
+        return rc == EOK;
 }
 
@@ -365 +373 @@
     isdv4_event_fn event_fn)
 {
+        chardev_t *chardev;
+        int rc;
+
+        rc = chardev_open(sess, &chardev);
+        if (rc != EOK)
+                return rc;
+
         memset(state, 0, sizeof(isdv4_state_t));
+
         state->sess = sess;
+        state->chardev = chardev;
+
         state->buf = malloc(BUF_SIZE);
-        if (state->buf == NULL)
+        if (state->buf == NULL) {
+                chardev_close(chardev);
                 return ENOMEM;
+        }
+
         state->buf_size = BUF_SIZE;
         state->emit_event_fn = event_fn;
@@ -377 +398 @@
 int isdv4_init_tablet(isdv4_state_t *state)
 {
-        if (!write_command(state->sess, CMD_STOP))
+        if (!write_command(state->chardev, CMD_STOP))
                 return EIO;
 
@@ -383 +404 @@
 
         // FIXME: Read all possible garbage before sending commands
-        if (!write_command(state->sess, CMD_QUERY_STYLUS))
+        if (!write_command(state->chardev, CMD_QUERY_STYLUS))
                 return EIO;
 
@@ -390 +411 @@
                 return rc;
 
-        if (!write_command(state->sess, CMD_QUERY_TOUCH))
+        if (!write_command(state->chardev, CMD_QUERY_TOUCH))
                 return EIO;
 
@@ -397 +418 @@
                 return rc;
 
-        if (!write_command(state->sess, CMD_START))
+        if (!write_command(state->chardev, CMD_START))
                 return EIO;