Changeset 737ebf3 in mainline for uspace/srv/hid/compositor/compositor.c

Timestamp:

2018-12-11T15:46:31Z (5 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

c9c1ccd

Parents:

10b21a1b

Message:

Fix window reference leak in compositor.

File:

• uspace/srv/hid/compositor/compositor.c (modified) (3 diffs)

uspace/srv/hid/compositor/compositor.c

@@ -224 +224 @@
 
         link_initialize(&win->link);
+        /* One initial reference will be for being in the window list */
         refcount_init(&win->ref_cnt);
         prodcons_initialize(&win->queue);
@@ -241 +242 @@
 static void window_destroy(window_t *win)
 {
-        if (!win || !refcount_down(&win->ref_cnt))
+        if (win == NULL)
+                return;
+
+        if (!refcount_down(&win->ref_cnt))
                 return;
 
@@ -891 +895 @@
                     0, 0, width, height, win->transform, &x, &y, &width, &height);
         }
+
+        /* Down refcount for removing from the window list */
+        window_destroy(win);
 
         comp_damage(x, y, width, height);