Changeset 6832245 in mainline for uspace/drv/bus/usb/xhci/hc.c

Timestamp:

2017-12-14T23:01:57Z (6 years ago)

Author:

Ondřej Hlavatý <aearsis@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

837d53d

Parents:

bd05140

git-author:

Ondřej Hlavatý <aearsis@…> (2017-12-14 23:01:54)

git-committer:

Ondřej Hlavatý <aearsis@…> (2017-12-14 23:01:57)

Message:

usbhost bus: refactor the bus ops

This way, method names better represent the entity it is working with.
Their semantics was shifted a bit.

Regarding the tree of structures:

bus ← device ← endpoint ← batch

Previously, devices were kept in DDF function nodes, and endpoints had
pointer to the bus and device. Now, devices have pointer to bus,
endpoints don't.

Pointer to hcd_t in bus is WIP, and will be removed.

File:

• uspace/drv/bus/usb/xhci/hc.c (modified) (1 diff)

uspace/drv/bus/usb/xhci/hc.c

@@ -212 +212 @@
                 goto err_scratch;
 
+        if ((err = xhci_bus_init(&hc->bus, hc)))
+                goto err_cmd;
+
         if ((err = xhci_rh_init(&hc->rh, hc, device)))
-                goto err_cmd;
-
-        if ((err = xhci_bus_init(&hc->bus, hc)))
-                goto err_rh;
-
-
-        return EOK;
-
-err_rh:
-        xhci_rh_fini(&hc->rh);
+                goto err_bus;
+
+        return EOK;
+
+err_bus:
+        xhci_bus_fini(&hc->bus);
 err_cmd:
         xhci_fini_commands(hc);