Changeset 5f6e25e in mainline for uspace/drv/bus/usb/usbhid/usbhid.c

Timestamp:

2011-08-29T23:00:12Z (13 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

58cbb0c8

Parents:

c5be39b

Message:

Leave it up to DDF to free driver-specific data. This makes it possible
to ensure soft state is not freed during calls to driver entry points.

This requires some driver changes:

• minimum change is not to free() driver-data structures (ddf_fun_t.driver_data and ddf_dev_t.driver_data)
• ideally allocate using ddf_dev_data_alloc(), ddf_fun_data_alloc()

I tried fixing existing drivers accordingly (mostly the minimalistic
change variant), but could have missed something.

File:

• uspace/drv/bus/usb/usbhid/usbhid.c (modified) (2 diffs)

uspace/drv/bus/usb/usbhid/usbhid.c

@@ -627 +627 @@
         }
         
-        usb_hid_free(&hid_dev);
+        usb_hid_destroy(hid_dev);
 }
 
@@ -646 +646 @@
 /*----------------------------------------------------------------------------*/
 
-void usb_hid_free(usb_hid_dev_t **hid_dev)
+void usb_hid_destroy(usb_hid_dev_t *hid_dev)
 {
         int i;
         
-        if (hid_dev == NULL || *hid_dev == NULL) {
+        if (hid_dev == NULL) {
                 return;
         }
         
         usb_log_debug("Subdrivers: %p, subdriver count: %d\n", 
-            (*hid_dev)->subdrivers, (*hid_dev)->subdriver_count);
-        
-        assert((*hid_dev)->subdrivers != NULL 
-            || (*hid_dev)->subdriver_count == 0);
-        
-        for (i = 0; i < (*hid_dev)->subdriver_count; ++i) {
-                if ((*hid_dev)->subdrivers[i].deinit != NULL) {
-                        (*hid_dev)->subdrivers[i].deinit(*hid_dev,
-                            (*hid_dev)->subdrivers[i].data);
+            hid_dev->subdrivers, hid_dev->subdriver_count);
+        
+        assert(hid_dev->subdrivers != NULL 
+            || hid_dev->subdriver_count == 0);
+        
+        for (i = 0; i < hid_dev->subdriver_count; ++i) {
+                if (hid_dev->subdrivers[i].deinit != NULL) {
+                        hid_dev->subdrivers[i].deinit(hid_dev,
+                            hid_dev->subdrivers[i].data);
                 }
         }
         
         // free the subdrivers info
-        if ((*hid_dev)->subdrivers != NULL) {
-                free((*hid_dev)->subdrivers);
+        if (hid_dev->subdrivers != NULL) {
+                free(hid_dev->subdrivers);
         }
 
         // destroy the parser
-        if ((*hid_dev)->report != NULL) {
-                usb_hid_free_report((*hid_dev)->report);
-        }
-
-        if ((*hid_dev)->report_desc != NULL) {
-                free((*hid_dev)->report_desc);
-        }
-
-        free(*hid_dev);
-        *hid_dev = NULL;
+        if (hid_dev->report != NULL) {
+                usb_hid_free_report(hid_dev->report);
+        }
+
+        if (hid_dev->report_desc != NULL) {
+                free(hid_dev->report_desc);
+        }
 }