Changeset 5a8fbcb in mainline for tools/config.py

Timestamp:

2009-08-11T13:29:30Z (15 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

5ab1648

Parents:

040f5c1

Message:

better way of generating revision identification via bzr version-info

• display stderr to indicate any errors/warnings
• get revision number, uncommited flag, revision id
• ignore revision identification completely on exported trees

File:

• tools/config.py (modified) (3 diffs)

tools/config.py

@@ -34 +34 @@
 import os
 import re
-import commands
+import time
+import subprocess
 import xtui
 
@@ -225 +226 @@
         "Create output configuration"
         
-        revision = commands.getoutput('bzr version-info --custom --template="{revision_id}" 2> /dev/null')
-        timestamp = commands.getoutput('date "+%Y-%m-%d %H:%M:%S"')
+        timestamp = time.strftime("%Y-%m-%d %H:%M:%S", time.localtime())
+        version = subprocess.Popen(['bzr', 'version-info', '--custom', '--template={clean}:{revno}:{revision_id}'], stdout = subprocess.PIPE).communicate()[0].split(':')
+        
+        if (len(version) == 3):
+                revision = version[1]
+                if (version[0] != 1):
+                        revision += 'M'
+                revision += ' (%s)' % version[2]
+        else:
+                revision = None
         
         outmk = file(mkname, 'w')
@@ -266 +275 @@
                         outdf.write(' -D%s=%s -D%s_%s' % (varname, default, varname, default))
         
-        outmk.write('REVISION = %s\n' % revision)
+        if (revision is not None):
+                outmk.write('REVISION = %s\n' % revision)
+                outmc.write('#define REVISION %s\n' % revision)
+                outdf.write(' "-DREVISION=%s"' % revision)
+        
         outmk.write('TIMESTAMP = %s\n' % timestamp)
-        
-        outmc.write('#define REVISION %s\n' % revision)
         outmc.write('#define TIMESTAMP %s\n' % timestamp)
-        
-        outdf.write(' "-DREVISION=%s" "-DTIMESTAMP=%s"\n' % (revision, timestamp))
+        outdf.write(' "-DTIMESTAMP=%s"\n' % timestamp)
         
         outmk.close()