Changeset 59fb782 in mainline for kernel/generic/src/mm/backend_elf.c

Timestamp:

2013-03-24T19:38:18Z (11 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

d965dc3

Parents:

119b46e

Message:

Unify the use of virtual addresses and virtual page addresses in mm code.

• as_page_fault() accepts faulting address (if available) and propagates the faulting page further along
• backends' page_fault() handlers assume page fault address
• page_mapping_create/destroy/find() accept addresses, but pass only page and frame addresses along
• as_area_create(), as_area_resize() now test whether the address is page-aligned
• renames of various variables to better fit their purpose (address vs. page)
• no need to align the addresses in mips32 TLB exception handlers now

File:

• kernel/generic/src/mm/backend_elf.c (modified) (4 diffs)

kernel/generic/src/mm/backend_elf.c

@@ -235 +235 @@
  *
  * @param area          Pointer to the address space area.
- * @param addr          Faulting virtual address.
+ * @param upage         Faulting virtual page.
  * @param access        Access mode that caused the fault (i.e.
  *                      read/write/exec).
@@ -242 +242 @@
  *                      on success (i.e. serviced).
  */
-int elf_page_fault(as_area_t *area, uintptr_t addr, pf_access_t access)
+int elf_page_fault(as_area_t *area, uintptr_t upage, pf_access_t access)
 {
         elf_header_t *elf = area->backend_data.elf;
@@ -250 +250 @@
         uintptr_t frame;
         uintptr_t kpage;
-        uintptr_t upage;
         uintptr_t start_anon;
         size_t i;
@@ -257 +256 @@
         ASSERT(page_table_locked(AS));
         ASSERT(mutex_locked(&area->lock));
+        ASSERT(IS_ALIGNED(upage, PAGE_SIZE));
 
         if (!as_area_check_access(area, access))
                 return AS_PF_FAULT;
         
-        if (addr < ALIGN_DOWN(entry->p_vaddr, PAGE_SIZE))
+        if (upage < ALIGN_DOWN(entry->p_vaddr, PAGE_SIZE))
                 return AS_PF_FAULT;
         
-        if (addr >= entry->p_vaddr + entry->p_memsz)
+        if (upage >= entry->p_vaddr + entry->p_memsz)
                 return AS_PF_FAULT;
         
-        i = (addr - ALIGN_DOWN(entry->p_vaddr, PAGE_SIZE)) >> PAGE_WIDTH;
+        i = (upage - ALIGN_DOWN(entry->p_vaddr, PAGE_SIZE)) >> PAGE_WIDTH;
         base = (uintptr_t)
             (((void *) elf) + ALIGN_DOWN(entry->p_offset, PAGE_SIZE));
-
-        /* Virtual address of faulting page */
-        upage = ALIGN_DOWN(addr, PAGE_SIZE);
 
         /* Virtual address of the end of initialized part of segment */