Changeset 5410c04 in mainline for uspace/app/usbinfo/dev.c

Timestamp:

2011-04-09T16:11:41Z (13 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a9d67aa, c6394aa

Parents:

8e8b84f (diff), 7b715892 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Automatic pipe sessions

It is no longer necessary to start sessions on USB pipes manually.
Actually, the original functions usb_pipe_start/end_session are now
deprecated.

For sporadic transfers, you do not need to care about sessions at all.
For longer transfers, you may hint the library about it by calling
usb_pipe_start_long_transfer.

File:

• uspace/app/usbinfo/dev.c (modified) (4 diffs)

uspace/app/usbinfo/dev.c

@@ -50 +50 @@
 
         int rc;
+        bool transfer_started = false;
 
         rc = usb_device_connection_initialize(&dev->wire, hc_handle, dev_addr);
@@ -76 +77 @@
         }
 
-        rc = usb_pipe_start_session(&dev->ctrl_pipe);
+        rc = usb_pipe_start_long_transfer(&dev->ctrl_pipe);
         if (rc != EOK) {
                 fprintf(stderr,
-                    NAME ": failed to start session on control pipe: %s.\n",
+                    NAME ": failed to start transfer on control pipe: %s.\n",
                     str_error(rc));
                 goto leave;
         }
+        transfer_started = true;
 
         rc = usb_request_get_device_descriptor(&dev->ctrl_pipe,
@@ -107 +109 @@
 
 leave:
-        if (usb_pipe_is_session_started(&dev->ctrl_pipe)) {
-                usb_pipe_end_session(&dev->ctrl_pipe);
+        if (transfer_started) {
+                usb_pipe_end_long_transfer(&dev->ctrl_pipe);
         }
 
@@ -118 +120 @@
 void destroy_device(usbinfo_device_t *dev)
 {
-        usb_pipe_end_session(&dev->ctrl_pipe);
+        usb_pipe_end_long_transfer(&dev->ctrl_pipe);
         free(dev);
 }