Changeset 4f87a85a in mainline for uspace/drv/char/sun4v-con/sun4v-con.c

Timestamp:

2018-12-10T14:29:35Z (5 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

ca4c5596

Parents:

433d52f

git-author:

Jiri Svoboda <jiri@…> (2018-12-10 07:39:07)

git-committer:

Jiri Svoboda <jiri@…> (2018-12-10 14:29:35)

Message:

Check return code from ddf_add_fun_to_category

File:

• uspace/drv/char/sun4v-con/sun4v-con.c (modified) (3 diffs)

uspace/drv/char/sun4v-con/sun4v-con.c

@@ -74 +74 @@
         ddf_fun_t *fun = NULL;
         errno_t rc;
+        bool bound = false;
 
         con->res = *res;
@@ -113 +114 @@
         }
 
-        ddf_fun_add_to_category(fun, "console");
+        bound = true;
+
+        rc = ddf_fun_add_to_category(fun, "console");
+        if (rc != EOK) {
+                ddf_msg(LVL_ERROR, "Error adding function 'a' to category "
+                    "'console'.");
+                goto error;
+        }
 
         return EOK;
@@ -122 +130 @@
         if (con->output_buffer != (niagara_output_buffer_t *) AS_AREA_ANY)
                 physmem_unmap((void *) con->output_buffer);
+
+        if (bound)
+                ddf_fun_unbind(fun);
 
         if (fun != NULL)