Changeset 4f87a85a in mainline for uspace/drv/char/msim-con/msim-con.c

Timestamp:

2018-12-10T14:29:35Z (6 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

ca4c5596

Parents:

433d52f

git-author:

Jiri Svoboda <jiri@…> (2018-12-10 07:39:07)

git-committer:

Jiri Svoboda <jiri@…> (2018-12-10 14:29:35)

Message:

Check return code from ddf_add_fun_to_category

File:

• uspace/drv/char/msim-con/msim-con.c (modified) (3 diffs)

uspace/drv/char/msim-con/msim-con.c

@@ -85 +85 @@
         irq_cmd_t *msim_cmds = NULL;
         errno_t rc;
+        bool bound = false;
 
         circ_buf_init(&con->cbuf, con->buf, msim_con_buf_size, 1);
@@ -143 +144 @@
         }
 
-        ddf_fun_add_to_category(fun, "console");
+        bound = true;
+
+        rc = ddf_fun_add_to_category(fun, "console");
+        if (rc != EOK) {
+                ddf_msg(LVL_ERROR, "Error adding function 'a' to category "
+                    "'console'.");
+                goto error;
+        }
 
         return EOK;
@@ -149 +157 @@
         if (CAP_HANDLE_VALID(con->irq_handle))
                 async_irq_unsubscribe(con->irq_handle);
+        if (bound)
+                ddf_fun_unbind(fun);
         if (fun != NULL)
                 ddf_fun_destroy(fun);