Changeset 4b1c7c6f in mainline for kernel/arch/riscv64/include/arch/mm/page.h

Timestamp:

2018-03-16T20:57:16Z (6 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Children:

6be2c13

Parents:

973be387

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-16 20:51:59)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-16 20:57:16)

Message:

Clean up PAGE_* flags.

Remove "nop flags", they are confusing for readers and any benefit they would
gain in self-documentation they lose in being used inconsistently.

Remove "PAGE_READ", the only place it's used meaningfully is the incomplete
RISC-V implementation, and most call sites assume read is implied.

File:

• kernel/arch/riscv64/include/arch/mm/page.h (modified) (3 diffs)

kernel/arch/riscv64/include/arch/mm/page.h

@@ -82 +82 @@
 
 /* Flags mask for non-leaf page table entries */
-#define NON_LEAF_MASK  (~(PAGE_READ | PAGE_WRITE | PAGE_EXEC))
+#define NON_LEAF_MASK  (~(PAGE_WRITE | PAGE_EXEC))
 
 /* Get PTE address accessors for each level. */
@@ -183 +183 @@
         pte_t *entry = &pt[i];
 
-        return (((!entry->valid) << PAGE_PRESENT_SHIFT) |
+        return (((!entry->valid) << PAGE_NOT_PRESENT_SHIFT) |
             (entry->user << PAGE_USER_SHIFT) |
-            (entry->readable << PAGE_READ_SHIFT) |
             (entry->writable << PAGE_WRITE_SHIFT) |
             (entry->executable << PAGE_EXEC_SHIFT) |
@@ -196 +195 @@
 
         entry->valid = !(flags & PAGE_NOT_PRESENT);
-        entry->readable = (flags & PAGE_READ) != 0;
+        entry->readable = 1;
         entry->writable = (flags & PAGE_WRITE) != 0;
         entry->executable = (flags & PAGE_EXEC) != 0;