Changeset 472c09d in mainline for uspace/srv/clip/clip.c

Timestamp:

2010-02-03T15:18:40Z (14 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

b4cbef1

Parents:

28be7fa

Message:

more consistent naming scheme:

async_data_blob_receive → async_data_receive
async_data_string_receive → async_string_receive
CLIPBOARD_TAG_BLOB → CLIPBOARD_TAG_DATA

async_data_receive can now check the granularity of the received data
async_string_receive can now return the raw size of the received data

replace several common patterns of async_data_write_receive/_finalize
with a single async_data_receive/_string_receive (this greatly improves
code readability)

File:

• uspace/srv/clip/clip.c (modified) (4 diffs)

uspace/srv/clip/clip.c

@@ -64 +64 @@
                 ipc_answer_0(rid, EOK);
                 break;
-        case CLIPBOARD_TAG_BLOB:
-                rc = async_data_blob_receive(&data, 0, &size);
+        case CLIPBOARD_TAG_DATA:
+                rc = async_data_receive(&data, 0, 0, &size);
                 if (rc != EOK) {
                         ipc_answer_0(rid, rc);
@@ -78 +78 @@
                 clip_data = data;
                 clip_size = size;
-                clip_tag = CLIPBOARD_TAG_BLOB;
+                clip_tag = CLIPBOARD_TAG_DATA;
                 
                 fibril_mutex_unlock(&clip_mtx);
@@ -97 +97 @@
         /* Check for clipboard data tag compatibility */
         switch (IPC_GET_ARG1(*request)) {
-        case CLIPBOARD_TAG_BLOB:
+        case CLIPBOARD_TAG_DATA:
                 if (!async_data_read_receive(&callid, &size)) {
                         ipc_answer_0(callid, EINVAL);
@@ -104 +104 @@
                 }
                 
-                if (clip_tag != CLIPBOARD_TAG_BLOB) {
-                        /* So far we only understand BLOB */
+                if (clip_tag != CLIPBOARD_TAG_DATA) {
+                        /* So far we only understand binary data */
                         ipc_answer_0(callid, EOVERFLOW);
                         ipc_answer_0(rid, EOVERFLOW);