Changeset 46b881c in mainline for uspace/srv/vfs/vfs_register.c

Timestamp:

2011-01-29T11:36:41Z (13 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0b6931a, 8add9ca5

Parents:

e26a4633 (diff), ffa2c8ef (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

IPC/async: strictly isolate the use of low-level IPC methods (ipc_*) and async framework methods (async_*) in user code, do not allow a mixture of both in a single source file

Benefits for future plans

• The async framework could use different communication style under the hood, but keeping the same high-level API
• The async framework can be integrated more tightly with sessions without potential problems of intermixing session-aware async methods with session-unaware low-level methods in user code
• The async_serialize_start()/_end() can be deprecated more easily

File:

• uspace/srv/vfs/vfs_register.c (modified) (10 diffs)

uspace/srv/vfs/vfs_register.c

@@ -36 +36 @@
  */
 
-#include <ipc/ipc.h>
 #include <ipc/services.h>
 #include <async.h>
@@ -122 +121 @@
                 dprintf("Failed to deliver the VFS info into our AS, rc=%d.\n",
                     rc);
-                ipc_answer_0(rid, rc);
+                async_answer_0(rid, rc);
                 return;
         }
@@ -132 +131 @@
         if (!fs_info) {
                 dprintf("Could not allocate memory for FS info.\n");
-                ipc_answer_0(rid, ENOMEM);
+                async_answer_0(rid, ENOMEM);
                 return;
         }
@@ -144 +143 @@
         if (!vfs_info_sane(&fs_info->vfs_info)) {
                 free(fs_info);
-                ipc_answer_0(rid, EINVAL);
+                async_answer_0(rid, EINVAL);
                 return;
         }
@@ -160 +159 @@
                 fibril_mutex_unlock(&fs_head_lock);
                 free(fs_info);
-                ipc_answer_0(rid, EEXISTS);
+                async_answer_0(rid, EEXISTS);
                 return;
         }
@@ -182 +181 @@
                 fibril_mutex_unlock(&fs_head_lock);
                 free(fs_info);
-                ipc_answer_0(callid, EINVAL);
-                ipc_answer_0(rid, EINVAL);
+                async_answer_0(callid, EINVAL);
+                async_answer_0(rid, EINVAL);
                 return;
         }
@@ -189 +188 @@
         phone = IPC_GET_ARG5(call);
         async_session_create(&fs_info->session, phone, 0);
-        ipc_answer_0(callid, EOK);
+        async_answer_0(callid, EOK);
         
         dprintf("Callback connection to FS created.\n");
@@ -203 +202 @@
                 fibril_mutex_unlock(&fs_head_lock);
                 async_session_destroy(&fs_info->session);
-                ipc_hangup(phone);
-                free(fs_info);
-                ipc_answer_0(callid, EINVAL);
-                ipc_answer_0(rid, EINVAL);
+                async_hangup(phone);
+                free(fs_info);
+                async_answer_0(callid, EINVAL);
+                async_answer_0(rid, EINVAL);
                 return;
         }
@@ -218 +217 @@
                 fibril_mutex_unlock(&fs_head_lock);
                 async_session_destroy(&fs_info->session);
-                ipc_hangup(phone);
-                free(fs_info);
-                ipc_answer_0(callid, EINVAL);
-                ipc_answer_0(rid, EINVAL);
+                async_hangup(phone);
+                free(fs_info);
+                async_answer_0(callid, EINVAL);
+                async_answer_0(rid, EINVAL);
                 return;
         }
@@ -239 +238 @@
          */
         fs_info->fs_handle = (fs_handle_t) atomic_postinc(&fs_handle_next);
-        ipc_answer_1(rid, EOK, (sysarg_t) fs_info->fs_handle);
+        async_answer_1(rid, EOK, (sysarg_t) fs_info->fs_handle);
         
         fibril_condvar_broadcast(&fs_head_cv);