Changeset 46577995 in mainline for uspace/app/getterm/getterm.c

Timestamp:

2018-01-04T20:50:52Z (6 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Children:

e211ea04

Parents:

facacc71

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-01-04 20:47:53)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-01-04 20:50:52)

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

After this commit, HelenOS is free of code that mixes error codes with non-error
values on the assumption that error codes are negative.

File:

• uspace/app/getterm/getterm.c (modified) (3 diffs)

uspace/app/getterm/getterm.c

@@ -67 +67 @@
         
         int oldfd;
-        int rc = vfs_lookup_open(path, WALK_REGULAR, mode, &oldfd);
+        errno_t rc = vfs_lookup_open(path, WALK_REGULAR, mode, &oldfd);
         if (rc != EOK)
                 return;
@@ -134 +134 @@
                 /* Wait for the terminal service to be ready */
                 service_id_t service_id;
-                int rc = loc_service_get_id(term, &service_id, IPC_FLAG_BLOCKING);
+                errno_t rc = loc_service_get_id(term, &service_id, IPC_FLAG_BLOCKING);
                 if (rc != EOK) {
                         printf("%s: Error waiting on %s (%s)\n", APP_NAME, term,
@@ -171 +171 @@
         task_wait_t twait;
         
-        int rc = task_spawnv(&id, &twait, cmd, (const char * const *) args);
+        errno_t rc = task_spawnv(&id, &twait, cmd, (const char * const *) args);
         if (rc != EOK) {
                 printf("%s: Error spawning %s (%s)\n", APP_NAME, cmd,