Changeset 45457265 in mainline for uspace/drv/bus/usb/xhci/commands.c

Timestamp:

2018-02-03T02:14:26Z (6 years ago)

Author:

Jenda <jenda.jzqk73@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

eb862fd

Parents:

961a5ee

Message:

errno_t all the things!

File:

• uspace/drv/bus/usb/xhci/commands.c (modified) (23 diffs)

uspace/drv/bus/usb/xhci/commands.c

@@ -72 +72 @@
  * reset before starting.
  */
-int xhci_init_commands(xhci_hc_t *hc)
+errno_t xhci_init_commands(xhci_hc_t *hc)
 {
         xhci_cmd_ring_t *cr = get_cmd_ring(hc);
-        int err;
+        errno_t err;
 
         if ((err = xhci_trb_ring_init(&cr->trb_ring, 0)))
@@ -172 +172 @@
 }
 
-static int wait_for_ring_open(xhci_cmd_ring_t *cr)
+static errno_t wait_for_ring_open(xhci_cmd_ring_t *cr)
 {
         assert(fibril_mutex_is_locked(&cr->guard));
@@ -194 +194 @@
  * Register the command as waiting for completion inside the command list.
  */
-static inline int enqueue_command(xhci_hc_t *hc, xhci_cmd_t *cmd)
+static inline errno_t enqueue_command(xhci_hc_t *hc, xhci_cmd_t *cmd)
 {
         xhci_cmd_ring_t *cr = get_cmd_ring(hc);
@@ -210 +210 @@
         list_append(&cmd->_header.link, &cr->cmd_list);
 
-        int err = EOK;
+        errno_t err = EOK;
         while (err == EOK) {
                 err = xhci_trb_ring_enqueue(&cr->trb_ring,
@@ -343 +343 @@
  * @param trb The COMMAND_COMPLETION TRB found in event ring.
  */
-int xhci_handle_command_completion(xhci_hc_t *hc, xhci_trb_t *trb)
+errno_t xhci_handle_command_completion(xhci_hc_t *hc, xhci_trb_t *trb)
 {
         xhci_cmd_ring_t *cr = get_cmd_ring(hc);
@@ -416 +416 @@
 /* Command-issuing functions */
 
-static int no_op_cmd(xhci_hc_t *hc, xhci_cmd_t *cmd)
+static errno_t no_op_cmd(xhci_hc_t *hc, xhci_cmd_t *cmd)
 {
         assert(hc);
@@ -427 +427 @@
 }
 
-static int enable_slot_cmd(xhci_hc_t *hc, xhci_cmd_t *cmd)
+static errno_t enable_slot_cmd(xhci_hc_t *hc, xhci_cmd_t *cmd)
 {
         assert(hc);
@@ -440 +440 @@
 }
 
-static int disable_slot_cmd(xhci_hc_t *hc, xhci_cmd_t *cmd)
+static errno_t disable_slot_cmd(xhci_hc_t *hc, xhci_cmd_t *cmd)
 {
         assert(hc);
@@ -453 +453 @@
 }
 
-static int address_device_cmd(xhci_hc_t *hc, xhci_cmd_t *cmd)
+static errno_t address_device_cmd(xhci_hc_t *hc, xhci_cmd_t *cmd)
 {
         assert(hc);
@@ -483 +483 @@
 }
 
-static int configure_endpoint_cmd(xhci_hc_t *hc, xhci_cmd_t *cmd)
+static errno_t configure_endpoint_cmd(xhci_hc_t *hc, xhci_cmd_t *cmd)
 {
         assert(hc);
@@ -504 +504 @@
 }
 
-static int evaluate_context_cmd(xhci_hc_t *hc, xhci_cmd_t *cmd)
+static errno_t evaluate_context_cmd(xhci_hc_t *hc, xhci_cmd_t *cmd)
 {
         assert(hc);
@@ -526 +526 @@
 }
 
-static int reset_endpoint_cmd(xhci_hc_t *hc, xhci_cmd_t *cmd)
+static errno_t reset_endpoint_cmd(xhci_hc_t *hc, xhci_cmd_t *cmd)
 {
         assert(hc);
@@ -541 +541 @@
 }
 
-static int stop_endpoint_cmd(xhci_hc_t *hc, xhci_cmd_t *cmd)
+static errno_t stop_endpoint_cmd(xhci_hc_t *hc, xhci_cmd_t *cmd)
 {
         assert(hc);
@@ -556 +556 @@
 }
 
-static int set_tr_dequeue_pointer_cmd(xhci_hc_t *hc, xhci_cmd_t *cmd)
+static errno_t set_tr_dequeue_pointer_cmd(xhci_hc_t *hc, xhci_cmd_t *cmd)
 {
         assert(hc);
@@ -572 +572 @@
 }
 
-static int reset_device_cmd(xhci_hc_t *hc, xhci_cmd_t *cmd)
+static errno_t reset_device_cmd(xhci_hc_t *hc, xhci_cmd_t *cmd)
 {
         assert(hc);
@@ -585 +585 @@
 }
 
-static int get_port_bandwidth_cmd(xhci_hc_t *hc, xhci_cmd_t *cmd)
+static errno_t get_port_bandwidth_cmd(xhci_hc_t *hc, xhci_cmd_t *cmd)
 {
         assert(hc);
@@ -603 +603 @@
 /* The table of command-issuing functions. */
 
-typedef int (*cmd_handler) (xhci_hc_t *hc, xhci_cmd_t *cmd);
+typedef errno_t (*cmd_handler) (xhci_hc_t *hc, xhci_cmd_t *cmd);
 
 static cmd_handler cmd_handlers [] = {
@@ -635 +635 @@
  * COMMAND_ABORTED event.
  */
-static int try_abort_current_command(xhci_hc_t *hc)
+static errno_t try_abort_current_command(xhci_hc_t *hc)
 {
         xhci_cmd_ring_t *cr = get_cmd_ring(hc);
@@ -694 +694 @@
  * until COMMAND_COMPLETION event arrives.
  */
-static int wait_for_cmd_completion(xhci_hc_t *hc, xhci_cmd_t *cmd)
-{
-        int rv = EOK;
+static errno_t wait_for_cmd_completion(xhci_hc_t *hc, xhci_cmd_t *cmd)
+{
+        errno_t rv = EOK;
 
         if (fibril_get_id() == hc->event_handler) {
@@ -731 +731 @@
  * expires. Nothing is deallocated. Caller should always execute `xhci_cmd_fini`.
  */
-int xhci_cmd_sync(xhci_hc_t *hc, xhci_cmd_t *cmd)
-{
-        assert(hc);
-        assert(cmd);
-
-        int err;
+errno_t xhci_cmd_sync(xhci_hc_t *hc, xhci_cmd_t *cmd)
+{
+        assert(hc);
+        assert(cmd);
+
+        errno_t err;
 
         if (!cmd_handlers[cmd->_header.cmd]) {
@@ -773 +773 @@
  * is a useful shorthand for issuing commands without out parameters.
  */
-int xhci_cmd_sync_fini(xhci_hc_t *hc, xhci_cmd_t *cmd)
-{
-        const int err = xhci_cmd_sync(hc, cmd);
+errno_t xhci_cmd_sync_fini(xhci_hc_t *hc, xhci_cmd_t *cmd)
+{
+        const errno_t err = xhci_cmd_sync(hc, cmd);
         xhci_cmd_fini(cmd);
 
@@ -785 +785 @@
  * fibril. The command is copied to stack memory and `fini` is called upon its completion.
  */
-int xhci_cmd_async_fini(xhci_hc_t *hc, xhci_cmd_t *stack_cmd)
+errno_t xhci_cmd_async_fini(xhci_hc_t *hc, xhci_cmd_t *stack_cmd)
 {
         assert(hc);
@@ -801 +801 @@
 
         /* Issue the command. */
-        int err;
+        errno_t err;
 
         if (!cmd_handlers[heap_cmd->_header.cmd]) {