Changeset 4125b7d in mainline for uspace/drv/ehci-hcd/main.c

Timestamp:

2011-04-18T20:06:55Z (13 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

84a04dd, bbdf09e

Parents:

5ab4a48

Message:

usb_log_printf() checks for printf correctness

It is surprising how many printf warnings simple check could
produce .

Next time, it won't compile. Bad, huh?

File:

• uspace/drv/ehci-hcd/main.c (modified) (2 diffs)

uspace/drv/ehci-hcd/main.c

@@ -82 +82 @@
             pci_get_my_registers(device, &mem_reg_base, &mem_reg_size, &irq);
         CHECK_RET_RETURN(ret,
-            "Failed(%d) to get memory addresses:.\n", ret, device->handle);
-        usb_log_info("Memory mapped regs at 0x%X (size %zu), IRQ %d.\n",
+            "Failed to get memory addresses for %" PRIun ": %s.\n",
+            device->handle, str_error(ret));
+        usb_log_info("Memory mapped regs at 0x%" PRIxn " (size %zu), IRQ %d.\n",
             mem_reg_base, mem_reg_size, irq);
 
@@ -102 +103 @@
             str_error(ret));
 
-        usb_log_info("Controlling new EHCI device `%s' (handle %llu).\n",
+        usb_log_info("Controlling new EHCI device `%s' (handle %" PRIun ").\n",
             device->name, device->handle);