Changeset 3fb5a3e in mainline for uspace/drv/usbhub/usbhub.h

Timestamp:

2011-05-28T14:34:43Z (13 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

af6136d

Parents:

400735e

Message:

Do not delete hub info too early

When a hub is disconnected during port change (device adding) the
structure was deleted and accessed *later* from the device adding
routine. Because allocator is next fit, the error went unnoticed.

File:

• uspace/drv/usbhub/usbhub.h (modified) (1 diff)

uspace/drv/usbhub/usbhub.h

@@ -89 +89 @@
         /** generic usb device data*/
         usb_device_t * usb_device;
+
+        /** Number of pending operations on the mutex to prevent shooting
+         * ourselves in the foot.
+         * When the hub is disconnected but we are in the middle of some
+         * operation, we cannot destroy this structure right away because
+         * the pending operation might use it.
+         */
+        size_t pending_ops_count;
+        /** Guard for pending_ops_count. */
+        fibril_mutex_t pending_ops_mutex;
+        /** Condition variable for pending_ops_count. */
+        fibril_condvar_t pending_ops_cv;
+
 };