Changeset 35c37fc in mainline for uspace/drv/bus/usb/ehci/ehci_bus.c

Timestamp:

2018-01-05T20:15:08Z (6 years ago)

Author:

Ondřej Hlavatý <aearsis@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

9e5b162

Parents:

b60944b

git-author:

Ondřej Hlavatý <aearsis@…> (2018-01-05 16:11:04)

git-committer:

Ondřej Hlavatý <aearsis@…> (2018-01-05 20:15:08)

Message:

ehci: refactor to dma_buffers

One big hidden thing was refactored - now TDs are allocated in one
buffer together with setup and data buffers themselves. This reduces the
number of allocated pages per transfer to minimum.

File:

• uspace/drv/bus/usb/ehci/ehci_bus.c (modified) (3 diffs)

uspace/drv/bus/usb/ehci/ehci_bus.c

@@ -36 +36 @@
 #include <assert.h>
 #include <stdlib.h>
-#include <usb/host/utils/malloc32.h>
 #include <usb/host/bandwidth.h>
 #include <usb/debug.h>
@@ -90 +89 @@
 
         // TODO: extract USB2 information from desc
+        
+        if (dma_buffer_alloc(&ehci_ep->dma_buffer, sizeof(qh_t)))
+                return NULL;
 
-        ehci_ep->qh = malloc32(sizeof(qh_t));
-        if (ehci_ep->qh == NULL) {
-                free(ehci_ep);
-                return NULL;
-        }
+        ehci_ep->qh = ehci_ep->dma_buffer.virt;
 
         link_initialize(&ehci_ep->link);
@@ -111 +109 @@
         ehci_endpoint_t *instance = ehci_endpoint_get(ep);
 
-        free32(instance->qh);
+        dma_buffer_free(&instance->dma_buffer);
         free(instance);
 }