Changeset 336db295 in mainline for kernel/generic/src/udebug/udebug_ipc.c

Timestamp:

2010-01-23T14:25:32Z (14 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a074b4f

Parents:

9d3133d

Message:

Fix THREAD_READ, add AREAS_READ Udebug method. Add task dump utility.

File:

• kernel/generic/src/udebug/udebug_ipc.c (modified) (5 diffs)

kernel/generic/src/udebug/udebug_ipc.c

@@ -41 +41 @@
 #include <proc/task.h>
 #include <proc/thread.h>
+#include <mm/as.h>
 #include <arch.h>
 #include <errno.h>
@@ -165 +166 @@
 static void udebug_receive_thread_read(call_t *call)
 {
+        uintptr_t uspace_addr;
+        size_t buf_size;
+        void *buffer;
+        size_t copied, needed;
+        int rc;
+
+        uspace_addr = IPC_GET_ARG2(call->data); /* Destination address */
+        buf_size = IPC_GET_ARG3(call->data);    /* Dest. buffer size */
+
+        /*
+         * Read thread list. Variable n will be filled with actual number
+         * of threads times thread-id size.
+         */
+        rc = udebug_thread_read(&buffer, buf_size, &copied, &needed);
+        if (rc < 0) {
+                IPC_SET_RETVAL(call->data, rc);
+                ipc_answer(&TASK->kb.box, call);
+                return;
+        }
+
+        /*
+         * Make use of call->buffer to transfer data to caller's userspace
+         */
+
+        IPC_SET_RETVAL(call->data, 0);
+        /* ARG1=dest, ARG2=size as in IPC_M_DATA_READ so that
+           same code in process_answer() can be used 
+           (no way to distinguish method in answer) */
+        IPC_SET_ARG1(call->data, uspace_addr);
+        IPC_SET_ARG2(call->data, copied);
+        IPC_SET_ARG3(call->data, needed);
+        call->buffer = buffer;
+
+        ipc_answer(&TASK->kb.box, call);
+}
+
+/** Process an AREAS_READ call.
+ *
+ * Returns a list of address space areas in the current task, as an array
+ * of as_area_info_t structures.
+ *
+ * @param call  The call structure.
+ */
+static void udebug_receive_areas_read(call_t *call)
+{
         unative_t uspace_addr;
         unative_t to_copy;
-        unsigned total_bytes;
-        unsigned buf_size;
-        void *buffer;
-        size_t n;
-        int rc;
+        size_t data_size;
+        size_t buf_size;
+        void *data;
 
         uspace_addr = IPC_GET_ARG2(call->data); /* Destination address */
@@ -177 +221 @@
 
         /*
-         * Read thread list. Variable n will be filled with actual number
-         * of threads times thread-id size.
-         */
-        rc = udebug_thread_read(&buffer, buf_size, &n);
-        if (rc < 0) {
-                IPC_SET_RETVAL(call->data, rc);
-                ipc_answer(&TASK->kb.box, call);
-                return;
-        }
-
-        total_bytes = n;
-
-        /* Copy MAX(buf_size, total_bytes) bytes */
-
-        if (buf_size > total_bytes)
-                to_copy = total_bytes;
+         * Read area list.
+         */
+        as_get_area_info(AS, (as_area_info_t **) &data, &data_size);
+
+        /* Copy MAX(buf_size, data_size) bytes */
+
+        if (buf_size > data_size)
+                to_copy = data_size;
         else
                 to_copy = buf_size;
@@ -207 +243 @@
         IPC_SET_ARG2(call->data, to_copy);
 
-        IPC_SET_ARG3(call->data, total_bytes);
-        call->buffer = buffer;
-
-        ipc_answer(&TASK->kb.box, call);
-}
+        IPC_SET_ARG3(call->data, data_size);
+        call->buffer = data;
+
+        ipc_answer(&TASK->kb.box, call);
+}
+
 
 /** Process an ARGS_READ call.
@@ -331 +368 @@
                 udebug_receive_thread_read(call);
                 break;
+        case UDEBUG_M_AREAS_READ:
+                udebug_receive_areas_read(call);
+                break;
         case UDEBUG_M_ARGS_READ:
                 udebug_receive_args_read(call);