Changeset 26de91a in mainline for uspace/app/nettest1/nettest1.c

Timestamp:

2013-10-04T17:19:20Z (11 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

9749e47

Parents:

e2839d7

Message:

IPv4 and v6 should not need separate handling by a simple client that is just connecting to a host/address. Add IPv6/DNS support in applications where missing.

File:

• uspace/app/nettest1/nettest1.c (modified) (3 diffs)

uspace/app/nettest1/nettest1.c

@@ -38 +38 @@
 #include "print_error.h"
 
+#include <assert.h>
 #include <malloc.h>
 #include <stdio.h>
@@ -326 +327 @@
         }
         
-        char *addr_s = argv[argc - 1];
+        char *host = argv[argc - 1];
         
         /* Interpret as address */
-        inet_addr_t addr_addr;
-        rc = inet_addr_parse(addr_s, &addr_addr);
+        inet_addr_t iaddr;
+        rc = inet_addr_parse(host, &iaddr);
         
         if (rc != EOK) {
                 /* Interpret as a host name */
                 dnsr_hostinfo_t *hinfo = NULL;
-                rc = dnsr_name2host(addr_s, &hinfo, ipver_from_af(family));
+                rc = dnsr_name2host(host, &hinfo, ipver_from_af(family));
                 
                 if (rc != EOK) {
-                        printf("Error resolving host '%s'.\n", addr_s);
+                        printf("Error resolving host '%s'.\n", host);
                         return EINVAL;
                 }
                 
-                addr_addr = hinfo->addr;
-        }
-        
-        struct sockaddr_in addr;
-        struct sockaddr_in6 addr6;
-        uint16_t af = inet_addr_sockaddr_in(&addr_addr, &addr, &addr6);
+                iaddr = hinfo->addr;
+        }
+        
+        rc = inet_addr_sockaddr(&iaddr, port, &address, &addrlen);
+        if (rc != EOK) {
+                assert(rc == ENOMEM);
+                printf("Out of memory.\n");
+                return ENOMEM;
+        }
         
         if (family == AF_NONE)
-                family = af;
-        
-        if (af != family) {
+                family = address->sa_family;
+        
+        if (address->sa_family != family) {
                 printf("Address family does not match explicitly set family.\n");
                 return EINVAL;
-        }
-        
-        /* Prepare the address buffer */
-        
-        switch (af) {
-        case AF_INET:
-                addr.sin_port = htons(port);
-                address = (struct sockaddr *) &addr;
-                addrlen = sizeof(addr);
-                break;
-        case AF_INET6:
-                addr6.sin6_port = htons(port);
-                address = (struct sockaddr *) &addr6;
-                addrlen = sizeof(addr6);
-                break;
-        default:
-                fprintf(stderr, "Address family is not supported\n");
-                return EAFNOSUPPORT;
         }
         
@@ -437 +423 @@
             &time_before));
         
+        free(address);
+        
         if (verbose)
                 printf("Exiting\n");