Changeset 203b80c in mainline for uspace/lib/drv/generic/driver.c

Timestamp:

2018-01-29T00:55:34Z (6 years ago)

Author:

Ondřej Hlavatý <aearsis@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

702729e

Parents:

4c3fef4

git-author:

Ondřej Hlavatý <aearsis@…> (2018-01-29 00:55:32)

git-committer:

Ondřej Hlavatý <aearsis@…> (2018-01-29 00:55:34)

Message:

libdrv: fix leaking ddf_dev_t reference

Even though the permanent reference held by the device being added is
dropped correctly, the temporary reference added by remove/gone is not.
That caused leaking devices and parent sessions along with them (which
is the way we discovered it).

File:

• uspace/lib/drv/generic/driver.c (modified) (2 diffs)

uspace/lib/drv/generic/driver.c

@@ -199 +199 @@
                 dev_del_ref(dev);
         
+        dev_del_ref(dev);
         async_answer_0(iid, (sysarg_t) rc);
 }
@@ -227 +228 @@
                 dev_del_ref(dev);
         
+        dev_del_ref(dev);
         async_answer_0(iid, (sysarg_t) rc);
 }