Changeset 19e0560e in mainline for uspace/drv/usbhid/generic/hiddev.c

Timestamp:

2011-05-30T19:06:57Z (13 years ago)

Author:

Lubos Slovak <lubos.slovak@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

173922f

Parents:

1aba480

Message:

Removed a lot of disabled code and TODOs

File:

• uspace/drv/usbhid/generic/hiddev.c (modified) (3 diffs)

uspace/drv/usbhid/generic/hiddev.c

@@ -126 +126 @@
         }
         
-        /*! @todo This should probably be atomic. */
-//      if (usb_hid_report_ready()) {
-//              usb_log_debug2("Report ready, size: %zu\n", 
-//                  hid_dev->input_report_size);
-                
-//              usb_hid_report_received();
-//      } else {
-//              memset(buffer, 0, hid_dev->input_report_size);
-//      }
+        /*! @todo This should probably be somehow atomic. */
         memcpy(buffer, hid_dev->input_report, 
             hid_dev->input_report_size);
@@ -140 +132 @@
         *event_nr = usb_hid_report_number(hid_dev);
         
-        // clear the buffer so that it will not be received twice
-        //memset(hid_dev->input_report, 0, hid_dev->input_report_size);
-        
-        // note that we already received this report
-//      report_received = true;
         usb_log_debug2("OK\n");
         
@@ -184 +171 @@
         
         if (hid_dev->report_desc_size > size) {
-                return EINVAL;  // TODO: other error code
+                return EINVAL;
         }