Changeset 1871118 in mainline for kernel/generic/src/ipc/kbox.c

Timestamp:

2023-02-10T22:59:11Z (15 months ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

master, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

11d2c983

Parents:

daadfa6

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2023-02-10 22:53:12)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2023-02-10 22:59:11)

Message:

Make thread_t reference counted

This simplifies interaction between various locks and thread
lifespan, which simplifies things. For example, threads_lock can
now simply be a mutex protecting the global it was made for, and
nothing more.

File:

• kernel/generic/src/ipc/kbox.c (modified) (3 diffs)

kernel/generic/src/ipc/kbox.c

@@ -90 +90 @@
                 LOG("Join kb.thread.");
                 thread_join(TASK->kb.thread);
-                thread_detach(TASK->kb.thread);
+                thread_put(TASK->kb.thread);
                 LOG("...join done.");
                 TASK->kb.thread = NULL;
@@ -136 +136 @@
                 /* Only detach kbox thread unless already terminating. */
                 if (TASK->kb.finished == false) {
-                        /* Detach kbox thread so it gets freed from memory. */
-                        thread_detach(TASK->kb.thread);
+                        /* Release kbox thread so it gets freed from memory. */
+                        thread_put(TASK->kb.thread);
                         TASK->kb.thread = NULL;
                 }
@@ -247 +247 @@
                 }
 
-                task->kb.thread = kb_thread;
+                task->kb.thread = thread_ref(kb_thread);
                 thread_ready(kb_thread);
         }