Changeset 1585c7e in mainline for uspace/drv/uhci-hcd/transfer_list.c

Timestamp:

2011-03-25T17:03:49Z (13 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

da88eb82

Parents:

d93b3e3

Message:

Use control transfer lock for control transfers.

Use global done list for all transfer lists.

File:

• uspace/drv/uhci-hcd/transfer_list.c (modified) (3 diffs)

uspace/drv/uhci-hcd/transfer_list.c

@@ -142 +142 @@
  * this transfer list leading to the deadlock if its done inline.
  */
-void transfer_list_remove_finished(transfer_list_t *instance)
-{
-        assert(instance);
-
-        LIST_INITIALIZE(done);
+void transfer_list_remove_finished(transfer_list_t *instance, link_t *done)
+{
+        assert(instance);
+        assert(done);
 
         fibril_mutex_lock(&instance->guard);
@@ -158 +157 @@
                         /* Save for post-processing */
                         transfer_list_remove_batch(instance, batch);
-                        list_append(current, &done);
+                        list_append(current, done);
                 }
                 current = next;
@@ -164 +163 @@
         fibril_mutex_unlock(&instance->guard);
 
-        async_usleep(1000);
-        while (!list_empty(&done)) {
-                link_t *item = done.next;
-                list_remove(item);
-                usb_transfer_batch_t *batch =
-                    list_get_instance(item, usb_transfer_batch_t, link);
-                batch->next_step(batch);
-        }
 }
 /*----------------------------------------------------------------------------*/