Changeset 128c78b in mainline for uspace/drv/char/ns8250/ns8250.c

Timestamp:

2011-09-17T21:04:47Z (13 years ago)

Author:

Martin Sucha <sucha14@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

dfa48b0d

Parents:

a281aec5

Message:

Add checks and documentation to interrupt-enabling code in the ns8250 driver.

File:

• uspace/drv/char/ns8250/ns8250.c (modified) (1 diff)

uspace/drv/char/ns8250/ns8250.c

@@ -412 +412 @@
 static int ns8250_interrupt_enable(ns8250_t *ns)
 {
+        /*
+         * Enable interrupt using IRC service.
+         * TODO: This is a temporary solution until the device framework
+         * takes care of this itself.
+         */
         async_sess_t *irc_sess = service_connect_blocking(EXCHANGE_SERIALIZE,
             SERVICE_IRC, 0, 0);
+        if (!irc_sess) {
+                return EIO;
+        }
 
         async_exch_t *exch = async_exchange_begin(irc_sess);
+        if (!exch) {
+                return EIO;
+        }
         async_msg_1(exch, IRC_ENABLE_INTERRUPT, ns->irq);
         async_exchange_end(exch);