Changeset 0f2c80a in mainline for uspace/drv/infrastructure/rootamdm37x/amdm37x.c

Timestamp:

2012-11-22T12:54:38Z (11 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0ab362c

Parents:

c739102

Message:

rootamdm37x: Fix DPLL5 initialization.

Divisor was out of allowed range.

File:

• uspace/drv/infrastructure/rootamdm37x/amdm37x.c (modified) (1 diff)

uspace/drv/infrastructure/rootamdm37x/amdm37x.c

@@ -271 +271 @@
                 /* Compute divisors and multiplier
                  * See AMDM37x TRM p. 300 for the formula */
-                assert((base_freq % 100) == 0);
-                const unsigned mult = 1200;
-                const unsigned div = (base_freq / 100) - 1;
+                // TODO: base_freq does not have to be rounded to Mhz
+                // (that's why I used KHz as unit).
+                const unsigned mult = 120;
+                const unsigned div = (base_freq / 1000) - 1;
                 const unsigned div2 = 1;
+                if ( ((base_freq % 1000) != 0) || (div > 127)) {
+                        ddf_msg(LVL_ERROR, "Rounding error, or divisor to big "
+                            "freq: %d, div: %d", base_freq, div);
+                        return;
+                };
+                assert(div <= 127);
 
                 /* Set multiplier */