Changeset 0418050 in mainline for uspace/srv/devman/main.c

Timestamp:

2011-03-28T21:13:52Z (13 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

2afc54d, 9b415c9

Parents:

df147c7

Message:

Devman should reject attempt to connect to root function, instead of crashing.
(thx Vojtech Horky)

File:

• uspace/srv/devman/main.c (modified) (1 diff)

uspace/srv/devman/main.c

@@ -477 +477 @@
                 dev = fun->dev;
 
-        if (fun == NULL && dev == NULL) {
+        /*
+         * For a valid function to connect to we need a device. The root
+         * function, for example, has no device and cannot be connected to.
+         * This means @c dev needs to be valid regardless whether we are
+         * connecting to a device or to a function.
+         */
+        if (dev == NULL) {
                 printf(NAME ": devman_forward error - no device or function with "
                     "handle %" PRIun " was found.\n", handle);