Changeset fd07e526 in mainline for uspace/drv/bus/usb/uhci/hw_struct/queue_head.h

Timestamp:

2011-09-16T14:50:20Z (14 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

432a269, d1e18573

Parents:

47fecbb (diff), 82a31261 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge USB changes from bzr://krabicka.net/orome/helenos/usb/

• Move common HC code from uhci/ohci drivers to libusbhost
• Rewrite USB HC interface to have common read/write functions for all transfer types.
• Restructure hc drivers to avoid some hooks and void* casts
• Cleanup the code and remove unnecessary mallocs.

File:

• uspace/drv/bus/usb/uhci/hw_struct/queue_head.h (modified) (3 diffs)

uspace/drv/bus/usb/uhci/hw_struct/queue_head.h

@@ -58 +58 @@
         assert(instance);
 
-        instance->element = 0 | LINK_POINTER_TERMINATE_FLAG;
-        instance->next = 0 | LINK_POINTER_TERMINATE_FLAG;
+        instance->element = LINK_POINTER_TERM;
+        instance->next = LINK_POINTER_TERM;
 }
 /*----------------------------------------------------------------------------*/
@@ -71 +71 @@
 static inline void qh_set_next_qh(qh_t *instance, qh_t *next)
 {
-        uint32_t pa = addr_to_phys(next);
+        /* Physical address has to be below 4GB,
+         * it is an UHCI limitation and malloc32
+         * should guarantee this */
+        const uint32_t pa = addr_to_phys(next);
         if (pa) {
                 instance->next = LINK_POINTER_QH(pa);
@@ -88 +91 @@
 static inline void qh_set_element_td(qh_t *instance, td_t *td)
 {
-        uint32_t pa = addr_to_phys(td);
+        /* Physical address has to be below 4GB,
+         * it is an UHCI limitation and malloc32
+         * should guarantee this */
+        const uint32_t pa = addr_to_phys(td);
         if (pa) {
                 instance->element = LINK_POINTER_TD(pa);