Changeset f8375f7 in mainline for uspace/lib/memgfx/src/memgc.c

Timestamp:

2020-05-30T17:16:39Z (5 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

dbef30f

Parents:

cea9f0c

Message:

Communicate memory GC updates via callback function

This is what we want in most use cases. Allows us to expose memory GC
ops directly without interposing on them (greatly simplifying the code).
The previous behavior is easily achieved by supplying the right callback
function.

File:

• uspace/lib/memgfx/src/memgc.c (modified) (4 diffs)

uspace/lib/memgfx/src/memgc.c

@@ -123 +123 @@
  * @param rect Bounding rectangle
  * @param alloc Allocation info
+ * @param update_cb Function called to update a rectangle
+ * @param cb_arg Argument to callback function
  * @param rgc Place to store pointer to new memory GC
  *
@@ -128 +130 @@
  */
 errno_t mem_gc_create(gfx_rect_t *rect, gfx_bitmap_alloc_t *alloc,
-    mem_gc_t **rgc)
+    mem_gc_update_cb_t update_cb, void *cb_arg, mem_gc_t **rgc)
 {
         mem_gc_t *mgc = NULL;
@@ -159 +161 @@
         assert(alloc->pitch == rect->p1.x * (int)sizeof(uint32_t));
 
-        mem_gc_clear_update_rect(mgc);
+        mgc->update = update_cb;
+        mgc->cb_arg = cb_arg;
 
         *rgc = mgc;
@@ -198 +201 @@
 static void mem_gc_invalidate_rect(mem_gc_t *mgc, gfx_rect_t *rect)
 {
-        gfx_rect_t nrect;
-
-        gfx_rect_envelope(&mgc->upd_rect, rect, &nrect);
-        mgc->upd_rect = nrect;
-}
-
-void mem_gc_get_update_rect(mem_gc_t *mgc, gfx_rect_t *rect)
-{
-        *rect = mgc->upd_rect;
-}
-
-void mem_gc_clear_update_rect(mem_gc_t *mgc)
-{
-        mgc->upd_rect.p0.x = 0;
-        mgc->upd_rect.p0.y = 0;
-        mgc->upd_rect.p1.x = 0;
-        mgc->upd_rect.p1.y = 0;
+        mgc->update(mgc->cb_arg, rect);
 }