Changeset ed5367b in mainline for uspace/srv/sysman/connection_ctl.c

Timestamp:

2019-08-07T10:01:13Z (6 years ago)

Author:

Matthieu Riolo <matthieu.riolo@…>

Children:

a097c50

Parents:

68ae40a

git-author:

Michal Koutný <xm.koutny+hos@…> (2015-11-05 01:52:07)

git-committer:

Matthieu Riolo <matthieu.riolo@…> (2019-08-07 10:01:13)

Message:

sysman: Implement stopping units

Currently fails service monitoring because of taskman flawed event flags.
However, job closure works well.

File:

• uspace/srv/sysman/connection_ctl.c (modified) (3 diffs)

uspace/srv/sysman/connection_ctl.c

@@ -63 +63 @@
         job_del_ref(&job);
 }
+
+static void sysman_unit_handle(ipc_callid_t iid, ipc_call_t *icall)
+{
+        char *unit_name = NULL;
+        sysarg_t retval;
+
+        int rc = async_data_write_accept((void **) &unit_name, true,
+            0, 0, 0, NULL);
+        if (rc != EOK) {
+                retval = rc;
+                goto fail;
+        }
+
+        // TODO this is connection fibril, UNSYNCHRONIZED access to units!
+        unit_t *unit = repo_find_unit_by_name(unit_name);
+        if (unit == NULL) {
+                retval = ENOENT;
+                goto fail;
+        }
+
+        async_answer_1(iid, EOK, unit->handle);
+        goto finish;
+
+fail:
+        async_answer_0(iid, retval);
+finish:
+        free(unit_name);
+}
+
 static void sysman_unit_start(ipc_callid_t iid, ipc_call_t *icall)
 {
@@ -109 +138 @@
 finish:
         free(unit_name);
+}
+
+static void sysman_unit_stop(ipc_callid_t iid, ipc_call_t *icall)
+{
+        sysarg_t retval;
+
+        unit_handle_t handle = IPC_GET_ARG1(*icall);
+        int flags = IPC_GET_ARG2(*icall);
+        sysman_log(LVL_DEBUG2, "%s(%i, %x)", __func__, handle, flags);
+
+        // TODO this is connection fibril, UNSYNCHRONIZED access to units!
+        unit_t *unit = repo_find_unit_by_handle(handle);
+        if (unit == NULL) {
+                retval = ENOENT;
+                goto answer;
+        }
+
+        if (!(flags & IPC_FLAG_BLOCKING)) {
+                retval = sysman_run_job(unit, STATE_STOPPED, NULL, NULL);
+                goto answer;
+        }
+
+        ipc_callid_t *iid_ptr = box_callid(iid);
+        if (iid_ptr == NULL) {
+                retval = ENOMEM;
+                goto answer;
+        }
+        retval = sysman_run_job(unit, STATE_STOPPED, &answer_callback,
+            iid_ptr);
+        if (retval != EOK) {
+                goto answer;
+        }
+
+        /* Answer asynchronously from callback */
+        return;
+
+answer:
+        async_answer_0(iid, retval);
 }
 
@@ -220 +287 @@
 
                 switch (IPC_GET_IMETHOD(call)) {
+                case SYSMAN_CTL_UNIT_HANDLE:
+                        sysman_unit_handle(callid, &call);
+                        break;
                 case SYSMAN_CTL_UNIT_START:
                         sysman_unit_start(callid, &call);
+                        break;
+                case SYSMAN_CTL_UNIT_STOP:
+                        sysman_unit_stop(callid, &call);
                         break;
                 case SYSMAN_CTL_GET_UNITS: