Changeset e3038b4 in mainline for kernel/arch/amd64/src

Timestamp:

2010-06-28T22:45:51Z (15 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

49eb681

Parents:

05e3cb8 (diff), e4a4b44 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge unified panic architecture (Phase 1).

Note that this is still work in progress as there are the following sharp edges:

• imprecise detection of read/write accesses on some architectures
• missing or imperfect capability to print stack traces on some architectures
• istate_t on some architectures may contain too little valuable information
• basically all trap frames need to be reorganized to look like a normal stack frame on the stack trace so that there are no missing frames
• panic_common() could print more information about the current context such as the task name, thread name, ASID etc.
• functions that call panic_*() should be protected against inlining to avoid missing or confusing stack frames in the stack trace

Location:

kernel/arch/amd64/src

Files:

• asm_utils.S (modified) (3 diffs)
• interrupt.c (modified) (5 diffs)
• mm/page.c (modified) (1 diff)

kernel/arch/amd64/src/asm_utils.S

@@ -51 +51 @@
 .global interrupt_handlers
 .global syscall_entry
-.global panic_printf
-
-panic_printf:
-        movabsq $halt, %rax
-        movq %rax, (%rsp)
-        jmp printf
-
 .global cpuid
 .global has_cpuid
@@ -234 +227 @@
         save_all_gpr
         cld
-        
-        # Stop stack traces here
-        xorq %rbp, %rbp
-        
-        movq $(\i), %rdi    # %rdi - first parameter
-        movq %rsp, %rsi     # %rsi - pointer to istate
-        call exc_dispatch   # exc_dispatch(i, istate)
+
+        #
+        # Stop stack traces here if we came from userspace.
+        #
+        movq %cs, %rax
+        xorq %rdx, %rdx
+        cmpq %rax, IREGISTER_SPACE+16(%rsp)
+        cmovneq %rdx, %rbp
+
+        movq $(\i), %rdi        # %rdi - first parameter
+        movq %rsp, %rsi         # %rsi - pointer to istate
+        call exc_dispatch       # exc_dispatch(i, istate)
         
         restore_all_gpr
@@ -290 +288 @@
         pushq %rcx
         pushq %r11
-        
-        movq %r10, %rcx   # Copy the 4th argument where it is expected 
+        pushq %rbp
+
+        xorq %rbp, %rbp         # stop the stack traces here
+
+        movq %r10, %rcx         # Copy the 4th argument where it is expected 
         pushq %rax
         call syscall_handler
         addq $8, %rsp
-        
+                
+        popq %rbp
         popq %r11
         popq %rcx

kernel/arch/amd64/src/interrupt.c

@@ -63 +63 @@
 void (* eoi_function)(void) = NULL;
 
-void decode_istate(int n, istate_t *istate)
-{
-        const char *symbol = symtab_fmt_name_lookup(istate->rip);
-        
-        printf("-----EXCEPTION(%d) OCCURED----- ( %s )\n", n, __func__);
-        printf("%%rip: %#llx (%s)\n", istate->rip, symbol);
-        printf("ERROR_WORD=%#llx\n", istate->error_word);
-        printf("%%cs=%#llx, rflags=%#llx, %%cr0=%#llx\n", istate->cs,
-            istate->rflags, read_cr0());
-        printf("%%rax=%#llx, %%rcx=%#llx, %%rdx=%#llx\n", istate->rax,
+void istate_decode(istate_t *istate)
+{
+        printf("error_word=%#llx\n", istate->error_word);
+        printf("cs =%#0.16llx\trflags=%#0.16llx\n", istate->cs,
+            istate->rflags);
+        printf("rax=%#0.16llx\trbx=%#0.16llx\trcx=%#0.16llx\n", istate->rax,
             istate->rcx, istate->rdx);
-        printf("%%rsi=%#llx, %%rdi=%#llx, %%r8=%#llx\n", istate->rsi,
+        printf("rsi=%#0.16llx\trdi=%#0.16llx\tr8 =%#0.16llx\n", istate->rsi,
             istate->rdi, istate->r8);
-        printf("%%r9=%#llx, %%r10=%#llx, %%r11=%#llx\n", istate->r9,
+        printf("r9 =%#0.16llx\tr10=%#0.16llx\tr11=%#0.16llx\n", istate->r9,
             istate->r10, istate->r11);
-        printf("%%rsp=%#llx\n", &istate->stack[0]);
-        
-        stack_trace_istate(istate);
 }
 
@@ -95 +88 @@
 {
         fault_if_from_uspace(istate, "Unserviced interrupt: %u.", n);
-        decode_istate(n, istate);
-        panic("Unserviced interrupt.");
+        panic_badtrap(istate, n, "Unserviced interrupt.");
 }
 
@@ -102 +94 @@
 {
         fault_if_from_uspace(istate, "Divide error.");
-        decode_istate(n, istate);
-        panic("Divide error.");
+        panic_badtrap(istate, n, "Divide error.");
 }
 
@@ -129 +120 @@
                 fault_if_from_uspace(istate, "General protection fault.");
         }
-        
-        decode_istate(n, istate);
-        panic("General protection fault.");
+        panic_badtrap(istate, n, "General protection fault.");
 }
 
@@ -137 +126 @@
 {
         fault_if_from_uspace(istate, "Stack fault.");
-        decode_istate(n, istate);
-        panic("Stack fault.");
+        panic_badtrap(istate, n, "Stack fault.");
 }
 

kernel/arch/amd64/src/mm/page.c

@@ -89 +89 @@
         
         if (as_page_fault(page, access, istate) == AS_PF_FAULT) {
-                fault_if_from_uspace(istate, "Page fault: %p.", page);
-                decode_istate(n, istate);
-                panic("Page fault: %p", page);
+                fault_if_from_uspace(istate, "Page fault: %#x.", page);
+                panic_memtrap(istate, access, page, "Page fault.");
         }
 }