Changeset dba056b in mainline for uspace/srv/sysman/sysman.c

Timestamp:

2019-08-06T19:23:56Z (6 years ago)

Author:

Matthieu Riolo <matthieu.riolo@…>

Children:

c6d87c10

Parents:

3f05ef7

git-author:

Michal Koutný <xm.koutny+hos@…> (2015-06-20 01:04:31)

git-committer:

Matthieu Riolo <matthieu.riolo@…> (2019-08-06 19:23:56)

Message:

sysman: Using exposees to detect asynchronous start

• also fixed bug with reference counting of merged jobs
• add test for the faulty behavior

File:

• uspace/srv/sysman/sysman.c (modified) (4 diffs)

uspace/srv/sysman/sysman.c

@@ -196 +196 @@
 /** Create and queue job for unit
  *
- * If unit already has the same job assigned callback is set to it.
+ * If unit already has the same job assigned callback is moved to it.
  *
  * @param[in]  callback  (optional) callback must explicitly delete reference
@@ -213 +213 @@
         if (callback != NULL) {
                 job_add_ref(job);
+                //TODO sysman_object_observer is not fibril-safe CANNOT BE CALLED HERE!
                 sysman_object_observer(job, callback, callback_arg);
         }
@@ -328 +329 @@
 }
 
+size_t sysman_observers_count(void *object)
+{
+        ht_link_t *ht_link = hash_table_find(&observed_objects, &object);
+
+        if (ht_link == NULL) {
+                return 0;
+        }
+
+        observed_object_t *observed_object =
+            hash_table_get_inst(ht_link, observed_object_t, ht_link);
+
+        return list_count(&observed_object->callbacks);
+}
+
 
 /*
@@ -355 +370 @@
                 goto fail;
         }
+
         /* We don't need job anymore */
         job_del_ref(&job);