Changeset ce794342 in mainline for uspace/drv/uhci-hcd

Timestamp:

2011-03-21T18:21:46Z (15 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

31b568e

Parents:

434ef65 (diff), fbefd0e (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Logging refactoring

Location:

uspace/drv/uhci-hcd

Files:

• main.c (modified) (3 diffs)
• uhci.c (modified) (1 diff)
• uhci_hc.c (modified) (1 diff)

uspace/drv/uhci-hcd/main.c

@@ -62 +62 @@
 int uhci_add_device(ddf_dev_t *device)
 {
-        usb_log_info("uhci_add_device() called\n");
+        usb_log_debug("uhci_add_device() called\n");
         assert(device);
         uhci_t *uhci = malloc(sizeof(uhci_t));
@@ -72 +72 @@
         int ret = uhci_init(uhci, device);
         if (ret != EOK) {
-                usb_log_error("Failed to initialzie UHCI driver.\n");
+                usb_log_error("Failed to initialize UHCI driver: %s.\n",
+                    str_error(ret));
                 return ret;
         }
         device->driver_data = uhci;
+
+        usb_log_info("Controlling new UHCI device `%s'.\n", device->name);
+
         return EOK;
 }
@@ -89 +93 @@
 int main(int argc, char *argv[])
 {
+        printf(NAME ": HelenOS UHCI driver.\n");
+
         sleep(3); /* TODO: remove in final version */
-        usb_log_enable(USB_LOG_LEVEL_DEBUG, NAME);
+        usb_log_enable(USB_LOG_LEVEL_DEFAULT, NAME);
 
         return ddf_driver_main(&uhci_driver);

uspace/drv/uhci-hcd/uhci.c

@@ -167 +167 @@
         CHECK_RET_DEST_FUN_RETURN(ret,
             "Failed(%d) to get I/O addresses:.\n", ret, device->handle);
-        usb_log_info("I/O regs at 0x%X (size %zu), IRQ %d.\n",
+        usb_log_debug("I/O regs at 0x%X (size %zu), IRQ %d.\n",
             io_reg_base, io_reg_size, irq);
 

uspace/drv/uhci-hcd/uhci_hc.c

@@ -128 +128 @@
         fibril_add_ready(instance->debug_checker);
 
-        usb_log_info("Started UHCI driver.\n");
         return EOK;
 #undef CHECK_RET_DEST_FUN_RETURN