Changeset b7fd2a0 in mainline for uspace/srv/net/tcp/conn.c

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/net/tcp/conn.c (modified) (4 diffs)

uspace/srv/net/tcp/conn.c

@@ -84 +84 @@
 
 /** Initialize connections. */
-int tcp_conns_init(void)
-{
-        int rc;
+errno_t tcp_conns_init(void)
+{
+        errno_t rc;
 
         rc = amap_create(&amap);
@@ -303 +303 @@
  * Add connection to the connection map.
  */
-int tcp_conn_add(tcp_conn_t *conn)
+errno_t tcp_conn_add(tcp_conn_t *conn)
 {
         inet_ep2_t aepp;
-        int rc;
+        errno_t rc;
 
         tcp_conn_addref(conn);
@@ -425 +425 @@
 tcp_conn_t *tcp_conn_find_ref(inet_ep2_t *epp)
 {
-        int rc;
+        errno_t rc;
         void *arg;
         tcp_conn_t *conn;
@@ -1242 +1242 @@
         inet_ep2_t aepp;
         inet_ep2_t oldepp;
-        int rc;
+        errno_t rc;
 
         log_msg(LOG_DEFAULT, LVL_DEBUG, "%s: tcp_conn_segment_arrived(%p)",