Changeset b7fd2a0 in mainline for uspace/srv/net/inetsrv/pdu.c

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/net/inetsrv/pdu.c (modified) (6 diffs)

uspace/srv/net/inetsrv/pdu.c

@@ -102 +102 @@
  *
  */
-int inet_pdu_encode(inet_packet_t *packet, addr32_t src, addr32_t dest,
+errno_t inet_pdu_encode(inet_packet_t *packet, addr32_t src, addr32_t dest,
     size_t offs, size_t mtu, void **rdata, size_t *rsize, size_t *roffs)
 {
@@ -194 +194 @@
  *
  */
-int inet_pdu_encode6(inet_packet_t *packet, addr128_t src, addr128_t dest,
+errno_t inet_pdu_encode6(inet_packet_t *packet, addr128_t src, addr128_t dest,
     size_t offs, size_t mtu, void **rdata, size_t *rsize, size_t *roffs)
 {
@@ -308 +308 @@
  *
  */
-int inet_pdu_decode(void *data, size_t size, service_id_t link_id,
+errno_t inet_pdu_decode(void *data, size_t size, service_id_t link_id,
     inet_packet_t *packet)
 {
@@ -385 +385 @@
  *
  */
-int inet_pdu_decode6(void *data, size_t size, service_id_t link_id,
+errno_t inet_pdu_decode6(void *data, size_t size, service_id_t link_id,
     inet_packet_t *packet)
 {
@@ -474 +474 @@
  *
  */
-int ndp_pdu_encode(ndp_packet_t *ndp, inet_dgram_t *dgram)
+errno_t ndp_pdu_encode(ndp_packet_t *ndp, inet_dgram_t *dgram)
 {
         inet_addr_set6(ndp->sender_proto_addr, &dgram->src);
@@ -535 +535 @@
  *
  */
-int ndp_pdu_decode(inet_dgram_t *dgram, ndp_packet_t *ndp)
+errno_t ndp_pdu_decode(inet_dgram_t *dgram, ndp_packet_t *ndp)
 {
         ip_ver_t src_ver = inet_addr_get(&dgram->src, NULL,