Changeset b7fd2a0 in mainline for uspace/srv/net/dnsrsrv/dns_msg.c

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/net/dnsrsrv/dns_msg.c (modified) (12 diffs)

uspace/srv/net/dnsrsrv/dns_msg.c

@@ -56 +56 @@
  * fit in and append @a suff.
  */
-static int dns_dstr_ext(char **dstr, const char *suff)
+static errno_t dns_dstr_ext(char **dstr, const char *suff)
 {
         size_t s1, s2;
@@ -93 +93 @@
  * @param act_size      Place to store actual encoded size
  */
-static int dns_name_encode(char *name, uint8_t *buf, size_t buf_size,
+static errno_t dns_name_encode(char *name, uint8_t *buf, size_t buf_size,
     size_t *act_size)
 {
@@ -158 +158 @@
  * @param eoff  Place to store end offset (offset after last decoded byte)
  */
-int dns_name_decode(dns_pdu_t *pdu, size_t boff, char **rname,
+errno_t dns_name_decode(dns_pdu_t *pdu, size_t boff, char **rname,
     size_t *eoff)
 {
@@ -169 +169 @@
         char *name;
         char dbuf[2];
-        int rc;
+        errno_t rc;
         bool first;
 
@@ -325 +325 @@
  * @param act_size      Place to store actual encoded size
  */
-static int dns_question_encode(dns_question_t *question, uint8_t *buf,
+static errno_t dns_question_encode(dns_question_t *question, uint8_t *buf,
     size_t buf_size, size_t *act_size)
 {
         size_t name_size;
         size_t di;
-        int rc;
+        errno_t rc;
 
         rc = dns_name_encode(question->qname, buf, buf_size, &name_size);
@@ -358 +358 @@
  * @param eoff          Place to store end offset (offset after last decoded byte)
  */
-static int dns_question_decode(dns_pdu_t *pdu, size_t boff,
+static errno_t dns_question_decode(dns_pdu_t *pdu, size_t boff,
     dns_question_t **rquestion, size_t *eoff)
 {
         dns_question_t *question;
         size_t name_eoff;
-        int rc;
+        errno_t rc;
 
         question = calloc(1, sizeof (dns_question_t));
@@ -398 +398 @@
  * @param eoff          Place to store end offset (offset after last decoded byte)
  */
-static int dns_rr_decode(dns_pdu_t *pdu, size_t boff, dns_rr_t **retrr,
+static errno_t dns_rr_decode(dns_pdu_t *pdu, size_t boff, dns_rr_t **retrr,
     size_t *eoff)
 {
@@ -406 +406 @@
         size_t bsz;
         size_t rdlength;
-        int rc;
+        errno_t rc;
 
         rr = calloc(1, sizeof(dns_rr_t));
@@ -492 +492 @@
  *              ENOMEM if out of memory
  */
-int dns_message_encode(dns_message_t *msg, void **rdata, size_t *rsize)
+errno_t dns_message_encode(dns_message_t *msg, void **rdata, size_t *rsize)
 {
         uint8_t *data;
@@ -499 +499 @@
         size_t q_size = 0;
         size_t di;
-        int rc;
+        errno_t rc;
 
         hdr.id = host2uint16_t_be(msg->id);
@@ -564 +564 @@
  *              ENOMEM if out of memory
  */
-int dns_message_decode(void *data, size_t size, dns_message_t **rmsg)
+errno_t dns_message_decode(void *data, size_t size, dns_message_t **rmsg)
 {
         dns_message_t *msg;
@@ -575 +575 @@
         size_t an_count;
         size_t i;
-        int rc;
+        errno_t rc;
 
         msg = dns_message_new();