Changeset b7fd2a0 in mainline for uspace/srv/audio/hound/audio_sink.c

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/audio/hound/audio_sink.c (modified) (4 diffs)

uspace/srv/audio/hound/audio_sink.c

@@ -56 +56 @@
  * @return Error code.
  */
-int audio_sink_init(audio_sink_t *sink, const char *name, void *private_data,
-    int (*connection_change)(audio_sink_t *, bool),
-    int (*check_format)(audio_sink_t *), int (*data_available)(audio_sink_t *),
+errno_t audio_sink_init(audio_sink_t *sink, const char *name, void *private_data,
+    errno_t (*connection_change)(audio_sink_t *, bool),
+    errno_t (*check_format)(audio_sink_t *), errno_t (*data_available)(audio_sink_t *),
     const pcm_format_t *f)
 {
@@ -97 +97 @@
  * @return Error code.
  */
-int audio_sink_set_format(audio_sink_t *sink, const pcm_format_t *format)
+errno_t audio_sink_set_format(audio_sink_t *sink, const pcm_format_t *format)
 {
         assert(sink);
@@ -114 +114 @@
         }
         if (sink->check_format) {
-                const int ret = sink->check_format(sink);
+                const errno_t ret = sink->check_format(sink);
                 if (ret != EOK && ret != ELIMIT) {
                         log_debug("Format check failed on sink %s", sink->name);
@@ -141 +141 @@
         pcm_format_silence(dest, size, &sink->format);
         list_foreach(sink->connections, sink_link, connection_t, conn) {
-                const int ret = connection_add_source_data(
+                const errno_t ret = connection_add_source_data(
                     conn, dest, size, sink->format);
                 if (ret != EOK) {