Changeset b7fd2a0 in mainline for uspace/lib/usbhid/src/hiddescriptor.c

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/usbhid/src/hiddescriptor.c (modified) (3 diffs)

uspace/lib/usbhid/src/hiddescriptor.c

@@ -134 +134 @@
  * @retval EOK If report structure was successfully initialized
  */
-int usb_hid_report_init(usb_hid_report_t *report)
+errno_t usb_hid_report_init(usb_hid_report_t *report)
 {
         if (report == NULL) {
@@ -162 +162 @@
  *
  */
-int usb_hid_report_append_fields(usb_hid_report_t *report,
+errno_t usb_hid_report_append_fields(usb_hid_report_t *report,
                 usb_hid_report_item_t *report_item) {
 
@@ -356 +356 @@
  * @retval EOK If report descriptor is successfully parsed
  */
-int usb_hid_parse_report_descriptor(usb_hid_report_t *report, 
+errno_t usb_hid_parse_report_descriptor(usb_hid_report_t *report, 
     const uint8_t *data, size_t size)
 {