Changeset b7fd2a0 in mainline for uspace/lib/usbdev/src/driver.c

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/usbdev/src/driver.c (modified) (6 diffs)

uspace/lib/usbdev/src/driver.c

@@ -52 +52 @@
  * @return Error code.
  */
-static int generic_device_add(ddf_dev_t *gen_dev)
+static errno_t generic_device_add(ddf_dev_t *gen_dev)
 {
         assert(driver);
@@ -60 +60 @@
         /* Initialize generic USB driver data. */
         const char *err_msg = NULL;
-        int rc = usb_device_create_ddf(gen_dev, driver->endpoints, &err_msg);
+        errno_t rc = usb_device_create_ddf(gen_dev, driver->endpoints, &err_msg);
         if (rc != EOK) {
                 usb_log_error("USB device `%s' init failed (%s): %s.\n",
@@ -81 +81 @@
  * @return Error code.
  */
-static int generic_device_remove(ddf_dev_t *gen_dev)
+static errno_t generic_device_remove(ddf_dev_t *gen_dev)
 {
         assert(driver);
@@ -89 +89 @@
         /* Just tell the driver to stop whatever it is doing */
         usb_device_t *usb_dev = ddf_dev_data_get(gen_dev);
-        const int ret = driver->ops->device_rem(usb_dev);
+        const errno_t ret = driver->ops->device_rem(usb_dev);
         if (ret != EOK)
                 return ret;
@@ -103 +103 @@
  * @return Error code.
  */
-static int generic_device_gone(ddf_dev_t *gen_dev)
+static errno_t generic_device_gone(ddf_dev_t *gen_dev)
 {
         assert(driver);
@@ -110 +110 @@
                 return ENOTSUP;
         usb_device_t *usb_dev = ddf_dev_data_get(gen_dev);
-        const int ret = driver->ops->device_gone(usb_dev);
+        const errno_t ret = driver->ops->device_gone(usb_dev);
         if (ret == EOK)
                 usb_device_destroy_ddf(gen_dev);