Changeset b7fd2a0 in mainline for uspace/lib/nic/include/nic_rx_control.h

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/nic/include/nic_rx_control.h (modified) (2 diffs)

uspace/lib/nic/include/nic_rx_control.h

@@ -114 +114 @@
 } __attribute__ ((packed)) vlan_header_t;
 
-extern int nic_rxc_init(nic_rxc_t *rxc);
-extern int nic_rxc_clear(nic_rxc_t *rxc);
-extern int nic_rxc_set_addr(nic_rxc_t *rxc,
+extern errno_t nic_rxc_init(nic_rxc_t *rxc);
+extern errno_t nic_rxc_clear(nic_rxc_t *rxc);
+extern errno_t nic_rxc_set_addr(nic_rxc_t *rxc,
         const nic_address_t *prev_addr, const nic_address_t *curr_addr);
 extern bool nic_rxc_check(const nic_rxc_t *rxc,
@@ -126 +126 @@
 extern void nic_rxc_unicast_get_mode(const nic_rxc_t *, nic_unicast_mode_t *,
         size_t max_count, nic_address_t *address_list, size_t *address_count);
-extern int nic_rxc_unicast_set_mode(nic_rxc_t *rxc, nic_unicast_mode_t mode,
+extern errno_t nic_rxc_unicast_set_mode(nic_rxc_t *rxc, nic_unicast_mode_t mode,
         const nic_address_t *address_list, size_t address_count);
 extern void nic_rxc_multicast_get_mode(const nic_rxc_t *,
         nic_multicast_mode_t *, size_t, nic_address_t *, size_t *);
-extern int nic_rxc_multicast_set_mode(nic_rxc_t *, nic_multicast_mode_t mode,
+extern errno_t nic_rxc_multicast_set_mode(nic_rxc_t *, nic_multicast_mode_t mode,
         const nic_address_t *address_list, size_t address_count);
 extern void nic_rxc_broadcast_get_mode(const nic_rxc_t *,
         nic_broadcast_mode_t *mode);
-extern int nic_rxc_broadcast_set_mode(nic_rxc_t *,
+extern errno_t nic_rxc_broadcast_set_mode(nic_rxc_t *,
         nic_broadcast_mode_t mode);
 extern void nic_rxc_blocked_sources_get(const nic_rxc_t *,
         size_t max_count, nic_address_t *address_list, size_t *address_count);
-extern int nic_rxc_blocked_sources_set(nic_rxc_t *,
+extern errno_t nic_rxc_blocked_sources_set(nic_rxc_t *,
         const nic_address_t *address_list, size_t address_count);
-extern int nic_rxc_vlan_get_mask(const nic_rxc_t *rxc, nic_vlan_mask_t *mask);
-extern int nic_rxc_vlan_set_mask(nic_rxc_t *rxc, const nic_vlan_mask_t *mask);
+extern errno_t nic_rxc_vlan_get_mask(const nic_rxc_t *rxc, nic_vlan_mask_t *mask);
+extern errno_t nic_rxc_vlan_set_mask(nic_rxc_t *rxc, const nic_vlan_mask_t *mask);
 
 #endif