Changeset b7fd2a0 in mainline for uspace/lib/ieee80211/include/ieee80211.h

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/ieee80211/include/ieee80211.h (modified) (8 diffs)

uspace/lib/ieee80211/include/ieee80211.h

@@ -106 +106 @@
          *
          */
-        int (*start)(struct ieee80211_dev *);
+        errno_t (*start)(struct ieee80211_dev *);
         
         /** Scan neighborhood for networks.
@@ -118 +118 @@
          *
          */
-        int (*scan)(struct ieee80211_dev *);
+        errno_t (*scan)(struct ieee80211_dev *);
         
         /** Handler for TX frames to be send from device.
@@ -132 +132 @@
          *
          */
-        int (*tx_handler)(struct ieee80211_dev *, void *, size_t);
+        errno_t (*tx_handler)(struct ieee80211_dev *, void *, size_t);
         
         /** Set device operating frequency to given value.
@@ -142 +142 @@
          *
          */
-        int (*set_freq)(struct ieee80211_dev *, uint16_t);
+        errno_t (*set_freq)(struct ieee80211_dev *, uint16_t);
         
         /** Callback to inform device about BSSID change.
@@ -152 +152 @@
          *
          */
-        int (*bssid_change)(struct ieee80211_dev *, bool);
+        errno_t (*bssid_change)(struct ieee80211_dev *, bool);
         
         /** Callback to setup encryption key in IEEE 802.11 device.
@@ -164 +164 @@
          *
          */
-        int (*key_config)(struct ieee80211_dev *,
+        errno_t (*key_config)(struct ieee80211_dev *,
             ieee80211_key_config_t *key_conf, bool);
 } ieee80211_ops_t;
@@ -170 +170 @@
 /* Initialization functions. */
 extern ieee80211_dev_t *ieee80211_device_create(void);
-extern int ieee80211_device_init(ieee80211_dev_t *, ddf_dev_t *);
-extern int ieee80211_init(ieee80211_dev_t *, ieee80211_ops_t *,
+extern errno_t ieee80211_device_init(ieee80211_dev_t *, ddf_dev_t *);
+extern errno_t ieee80211_init(ieee80211_dev_t *, ieee80211_ops_t *,
     ieee80211_iface_t *, nic_iface_t *, ddf_dev_ops_t *);
 
@@ -201 +201 @@
 
 /* Worker functions. */
-extern int ieee80211_rx_handler(ieee80211_dev_t *, void *, size_t);
+extern errno_t ieee80211_rx_handler(ieee80211_dev_t *, void *, size_t);
 
 #endif