Changeset b7fd2a0 in mainline for uspace/lib/http/src/http.c

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/http/src/http.c (modified) (4 diffs)

uspace/lib/http/src/http.c

@@ -47 +47 @@
 #include <http/receive-buffer.h>
 
-static int http_receive(void *client_data, void *buf, size_t buf_size,
+static errno_t http_receive(void *client_data, void *buf, size_t buf_size,
     size_t *nrecv)
 {
@@ -69 +69 @@
         
         http->buffer_size = 4096;
-        int rc = recv_buffer_init(&http->recv_buffer, http->buffer_size,
+        errno_t rc = recv_buffer_init(&http->recv_buffer, http->buffer_size,
             http_receive, http);
         if (rc != EOK) {
@@ -79 +79 @@
 }
 
-int http_connect(http_t *http)
+errno_t http_connect(http_t *http)
 {
         if (http->conn != NULL)
                 return EBUSY;
         
-        int rc = inet_host_plookup_one(http->host, ip_any, &http->addr, NULL,
+        errno_t rc = inet_host_plookup_one(http->host, ip_any, &http->addr, NULL,
             NULL);
         if (rc != EOK)
@@ -110 +110 @@
 }
 
-int http_close(http_t *http)
+errno_t http_close(http_t *http)
 {
         if (http->conn == NULL)