Changeset b7fd2a0 in mainline for uspace/lib/ext4/src/ialloc.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/ext4/src/ialloc.c (modified) (4 diffs)

uspace/lib/ext4/src/ialloc.c

@@ -97 +97 @@
  *
  */
-int ext4_ialloc_free_inode(ext4_filesystem_t *fs, uint32_t index, bool is_dir)
+errno_t ext4_ialloc_free_inode(ext4_filesystem_t *fs, uint32_t index, bool is_dir)
 {
         ext4_superblock_t *sb = fs->superblock;
@@ -105 +105 @@
         
         ext4_block_group_ref_t *bg_ref;
-        int rc = ext4_filesystem_get_block_group_ref(fs, block_group, &bg_ref);
+        errno_t rc = ext4_filesystem_get_block_group_ref(fs, block_group, &bg_ref);
         if (rc != EOK)
                 return rc;
@@ -175 +175 @@
  *
  */
-int ext4_ialloc_alloc_inode(ext4_filesystem_t *fs, uint32_t *index, bool is_dir)
+errno_t ext4_ialloc_alloc_inode(ext4_filesystem_t *fs, uint32_t *index, bool is_dir)
 {
         ext4_superblock_t *sb = fs->superblock;
@@ -188 +188 @@
                 /* Load block group to check */
                 ext4_block_group_ref_t *bg_ref;
-                int rc = ext4_filesystem_get_block_group_ref(fs, bgid, &bg_ref);
+                errno_t rc = ext4_filesystem_get_block_group_ref(fs, bgid, &bg_ref);
                 if (rc != EOK)
                         return rc;