Changeset b7fd2a0 in mainline for uspace/lib/drv/include/usbhc_iface.h


Ignore:
Timestamp:
2018-01-13T03:10:29Z (8 years ago)
Author:
Jiří Zárevúcky <zarevucky.jiri@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
a53ed3a
Parents:
36f0738
Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • uspace/lib/drv/include/usbhc_iface.h

    r36f0738 rb7fd2a0  
    4444#include <stdbool.h>
    4545
    46 extern int usbhc_read(async_exch_t *, usb_address_t, usb_endpoint_t,
     46extern errno_t usbhc_read(async_exch_t *, usb_address_t, usb_endpoint_t,
    4747    uint64_t, void *, size_t, size_t *);
    48 extern int usbhc_write(async_exch_t *, usb_address_t, usb_endpoint_t,
     48extern errno_t usbhc_write(async_exch_t *, usb_address_t, usb_endpoint_t,
    4949    uint64_t, const void *, size_t);
    5050
    5151/** Callback for outgoing transfer. */
    52 typedef void (*usbhc_iface_transfer_out_callback_t)(int, void *);
     52typedef void (*usbhc_iface_transfer_out_callback_t)(errno_t, void *);
    5353
    5454/** Callback for incoming transfer. */
    55 typedef void (*usbhc_iface_transfer_in_callback_t)(int, size_t, void *);
     55typedef void (*usbhc_iface_transfer_in_callback_t)(errno_t, size_t, void *);
    5656
    5757/** USB host controller communication interface. */
    5858typedef struct {
    59         int (*read)(ddf_fun_t *, usb_target_t, uint64_t, uint8_t *, size_t,
     59        errno_t (*read)(ddf_fun_t *, usb_target_t, uint64_t, uint8_t *, size_t,
    6060            usbhc_iface_transfer_in_callback_t, void *);
    61         int (*write)(ddf_fun_t *, usb_target_t, uint64_t, const uint8_t *,
     61        errno_t (*write)(ddf_fun_t *, usb_target_t, uint64_t, const uint8_t *,
    6262            size_t, usbhc_iface_transfer_out_callback_t, void *);
    6363} usbhc_iface_t;
Note: See TracChangeset for help on using the changeset viewer.