Changeset b7fd2a0 in mainline for uspace/lib/drv/include/pci_dev_iface.h

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/drv/include/pci_dev_iface.h (modified) (1 diff)

uspace/lib/drv/include/pci_dev_iface.h

@@ -45 +45 @@
 #define PCI_BASE_CLASS  0x0B
 
-extern int pci_config_space_read_8(async_sess_t *, uint32_t, uint8_t *);
-extern int pci_config_space_read_16(async_sess_t *, uint32_t, uint16_t *);
-extern int pci_config_space_read_32(async_sess_t *, uint32_t, uint32_t *);
+extern errno_t pci_config_space_read_8(async_sess_t *, uint32_t, uint8_t *);
+extern errno_t pci_config_space_read_16(async_sess_t *, uint32_t, uint16_t *);
+extern errno_t pci_config_space_read_32(async_sess_t *, uint32_t, uint32_t *);
 
-extern int pci_config_space_write_8(async_sess_t *, uint32_t, uint8_t);
-extern int pci_config_space_write_16(async_sess_t *, uint32_t, uint16_t);
-extern int pci_config_space_write_32(async_sess_t *, uint32_t, uint32_t);
+extern errno_t pci_config_space_write_8(async_sess_t *, uint32_t, uint8_t);
+extern errno_t pci_config_space_write_16(async_sess_t *, uint32_t, uint16_t);
+extern errno_t pci_config_space_write_32(async_sess_t *, uint32_t, uint32_t);
 
 /** PCI device communication interface. */
 typedef struct {
-        int (*config_space_read_8)(ddf_fun_t *, uint32_t address, uint8_t *data);
-        int (*config_space_read_16)(ddf_fun_t *, uint32_t address, uint16_t *data);
-        int (*config_space_read_32)(ddf_fun_t *, uint32_t address, uint32_t *data);
+        errno_t (*config_space_read_8)(ddf_fun_t *, uint32_t address, uint8_t *data);
+        errno_t (*config_space_read_16)(ddf_fun_t *, uint32_t address, uint16_t *data);
+        errno_t (*config_space_read_32)(ddf_fun_t *, uint32_t address, uint32_t *data);
 
-        int (*config_space_write_8)(ddf_fun_t *, uint32_t address, uint8_t data);
-        int (*config_space_write_16)(ddf_fun_t *, uint32_t address, uint16_t data);
-        int (*config_space_write_32)(ddf_fun_t *, uint32_t address, uint32_t data);
+        errno_t (*config_space_write_8)(ddf_fun_t *, uint32_t address, uint8_t data);
+        errno_t (*config_space_write_16)(ddf_fun_t *, uint32_t address, uint16_t data);
+        errno_t (*config_space_write_32)(ddf_fun_t *, uint32_t address, uint32_t data);
 } pci_dev_iface_t;