Changeset b7fd2a0 in mainline for uspace/lib/drv/generic/remote_battery_dev.c

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/drv/generic/remote_battery_dev.c (modified) (6 diffs)

uspace/lib/drv/generic/remote_battery_dev.c

@@ -47 +47 @@
  * @return         EOK on success or an error code
  */
-int
+errno_t
 battery_status_get(async_sess_t *sess, battery_status_t *batt_status)
 {
@@ -54 +54 @@
         async_exch_t *exch = async_exchange_begin(sess);
 
-        int const rc = async_req_1_1(exch, DEV_IFACE_ID(BATTERY_DEV_IFACE),
+        errno_t const rc = async_req_1_1(exch, DEV_IFACE_ID(BATTERY_DEV_IFACE),
             BATTERY_STATUS_GET, &status);
 
@@ -72 +72 @@
  * @return         EOK on success or an error code
  */
-int
+errno_t
 battery_charge_level_get(async_sess_t *sess, int *level)
 {
@@ -79 +79 @@
         async_exch_t *exch = async_exchange_begin(sess);
 
-        int const rc = async_req_1_1(exch, DEV_IFACE_ID(BATTERY_DEV_IFACE),
+        errno_t const rc = async_req_1_1(exch, DEV_IFACE_ID(BATTERY_DEV_IFACE),
             BATTERY_CHARGE_LEVEL_GET, &charge_level);
 
@@ -129 +129 @@
 
         battery_status_t batt_status;
-        const int rc = bops->battery_status_get(fun, &batt_status);
+        const errno_t rc = bops->battery_status_get(fun, &batt_status);
 
         if (rc != EOK)
@@ -155 +155 @@
 
         int battery_level;
-        const int rc = bops->battery_charge_level_get(fun, &battery_level);
+        const errno_t rc = bops->battery_charge_level_get(fun, &battery_level);
 
         if (rc != EOK)