Changeset b7fd2a0 in mainline for uspace/lib/c/include/io/con_srv.h

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/c/include/io/con_srv.h (modified) (2 diffs)

uspace/lib/c/include/io/con_srv.h

@@ -67 +67 @@
 
 struct con_ops {
-        int (*open)(con_srvs_t *, con_srv_t *);
-        int (*close)(con_srv_t *);
-        int (*read)(con_srv_t *, void *, size_t, size_t *);
-        int (*write)(con_srv_t *, void *, size_t, size_t *);
+        errno_t (*open)(con_srvs_t *, con_srv_t *);
+        errno_t (*close)(con_srv_t *);
+        errno_t (*read)(con_srv_t *, void *, size_t, size_t *);
+        errno_t (*write)(con_srv_t *, void *, size_t, size_t *);
         void (*sync)(con_srv_t *);
         void (*clear)(con_srv_t *);
         void (*set_pos)(con_srv_t *, sysarg_t col, sysarg_t row);
-        int (*get_pos)(con_srv_t *, sysarg_t *, sysarg_t *);
-        int (*get_size)(con_srv_t *, sysarg_t *, sysarg_t *);
-        int (*get_color_cap)(con_srv_t *, console_caps_t *);
+        errno_t (*get_pos)(con_srv_t *, sysarg_t *, sysarg_t *);
+        errno_t (*get_size)(con_srv_t *, sysarg_t *, sysarg_t *);
+        errno_t (*get_color_cap)(con_srv_t *, console_caps_t *);
         void (*set_style)(con_srv_t *, console_style_t);
         void (*set_color)(con_srv_t *, console_color_t, console_color_t,
@@ -82 +82 @@
         void (*set_rgb_color)(con_srv_t *, pixel_t, pixel_t);
         void (*set_cursor_visibility)(con_srv_t *, bool);
-        int (*get_event)(con_srv_t *, cons_event_t *);
+        errno_t (*get_event)(con_srv_t *, cons_event_t *);
 };
 
 extern void con_srvs_init(con_srvs_t *);
 
-extern int con_conn(ipc_callid_t, ipc_call_t *, con_srvs_t *);
+extern errno_t con_conn(ipc_callid_t, ipc_call_t *, con_srvs_t *);
 
 #endif